Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pass context to the Assembly #32994

Closed
mrgrain opened this issue Jan 17, 2025 · 2 comments · Fixed by #32996
Closed

Ability to pass context to the Assembly #32994

mrgrain opened this issue Jan 17, 2025 · 2 comments · Fixed by #32996
Assignees
Labels

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Jan 17, 2025

In the CLI context is stored and passed in the assembly through a magic global configuration object. We don't have that anymore in the toolkit, therefore we need to allow explicitly passing a context map.

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
moelasmar pushed a commit that referenced this issue Jan 24, 2025
### Issue #32994

Closes #32994

### Reason for this change

Previously it was not possible to provide external context.

### Description of changes

Cloud Assembly Source Builder now optionally take a Context object that is provided to the source when the assembly is produced.

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

(cherry picked from commit ebe9580)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant