Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(dynamodb): l2 construct for warm-throughput feature #32127

Closed
1 of 2 tasks
LeeroyHannigan opened this issue Nov 14, 2024 · 2 comments · Fixed by #32390
Closed
1 of 2 tasks

(dynamodb): l2 construct for warm-throughput feature #32127

LeeroyHannigan opened this issue Nov 14, 2024 · 2 comments · Fixed by #32390
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@LeeroyHannigan
Copy link
Contributor

Describe the feature

https://aws.amazon.com/blogs/database/pre-warming-amazon-dynamodb-tables-with-warm-throughput/

Use Case

Allow users pre-warm their DynamoDB tables using CDK

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

LATEST

Environment details (OS name and version, etc.)

MacOS
@LeeroyHannigan LeeroyHannigan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 14, 2024
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Nov 14, 2024
@LeeroyHannigan LeeroyHannigan mentioned this issue Nov 14, 2024
Closed
1 task
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 14, 2024
@khushail khushail self-assigned this Nov 14, 2024
@khushail
Copy link
Contributor

khushail commented Nov 14, 2024 •
edited
Loading

@LeeroyHannigan , thanks for submitting this request.
As mentioned in this article, Cloudformation supports the pre-warming to DynamoDB Table, you can pre-warm your table by passing in values for warm throughput during the table creation process. This is what I see in your PR.

Referenced topics -
provisionedThroughput
OnDemandThroughPut

Thanks for PR submission. Appreciate your efforts!

@khushail khushail added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 14, 2024
@khushail khushail removed their assignment Nov 14, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Open
@LeeroyHannigan LeeroyHannigan mentioned this issue Dec 5, 2024
Merged
1 task
GavinZZ pushed a commit that referenced this issue Dec 6, 2024
@LeeroyHannigan
feat(dynamodb): add warm-throughput to L2 constructs (#32390)
496bc78 
### Issue # (if applicable)

Closes #32127

### Reason for this change

New feature for DynamoDB

### Description of changes

Implemented warm throughput for Table and TableV2

### Description of how you validated changes

Unit + Integ tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

Co-authored-by: Lee Hannigan <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@LeeroyHannigan @khushail