fix(fsx): no validation error when hour property set to 24 in the LustreMaintenanceTime class.
#30342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
valued-contributor
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
atanaspam
pushed a commit
to atanaspam/aws-cdk
that referenced
this pull request
Jun 3, 2024
…LustreMaintenanceTime` class. (aws#30342) ### Issue # (if applicable) Closes aws#30341 ### Reason for this change The `hour` property in the `LustreMaintenanceTime` class should be between 0 and 23. But no validation error occurs when it is set to 24. ### Description of changes In the validate method, I changed it so that an error is thrown when the hour is greater than 23, instead of when the hour is greater than 24. This allows a validation error to occur when the hour is set to 24. ### Description of how you validated changes Changed unit tests and add integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
vdahlberg
pushed a commit
to vdahlberg/aws-cdk
that referenced
this pull request
Jun 10, 2024
…LustreMaintenanceTime` class. (aws#30342) ### Issue # (if applicable) Closes aws#30341 ### Reason for this change The `hour` property in the `LustreMaintenanceTime` class should be between 0 and 23. But no validation error occurs when it is set to 24. ### Description of changes In the validate method, I changed it so that an error is thrown when the hour is greater than 23, instead of when the hour is greater than 24. This allows a validation error to occur when the hour is set to 24. ### Description of how you validated changes Changed unit tests and add integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jun 29, 2024
This was referenced Jul 12, 2024
This was referenced Jul 19, 2024
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #30341
Reason for this change
The
hourproperty in theLustreMaintenanceTimeclass should be between 0 and 23.But no validation error occurs when it is set to 24.
Description of changes
In the validate method, I changed it so that an error is thrown when the hour is greater than 23, instead of when the hour is greater than 24.
This allows a validation error to occur when the hour is set to 24.
Description of how you validated changes
Changed unit tests and add integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license