-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_ecs.FargateTaskDefinition: pidmode Task unsupported #29995
aws_ecs.FargateTaskDefinition: pidmode Task unsupported #29995
Comments
yap, looks like we should remove that check. Are you able to get it deployed using this workaround?
We just need to make sure removing that check would not cause other issues. If it works great with you, feel free to submit a tiny PR for this. Thank you. |
#30020) ### Issue # (if applicable) Closes #29995. ### Reason for this change Only the `task` option is allowed for [`pidMode`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-taskdefinition.html#cfn-ecs-taskdefinition-pidmode) on Linux-based Fargate tasks. ### Description of changes This PR builds on the changes introduced in #29670 but fixes the handling of `pidMode` so that it matches the behavior allowed by CloudFormation and described in the [AWS User Guide](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-taskdefinition.html#cfn-ecs-taskdefinition-pidmode). ### Description of how you validated changes Updated the existing tests so that `task` is the only allowable `pidMode` setting if a Fargate task's OS is Linux-based. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Describe the bug
Reading the pidmode announcement here, the cloudformation description for pidMode here. It explains
task
is the only option. But currently the FargateTaskDefinition only allowshost
.Changing this to host will result in a failed deployment, because host isn't allowed on Fargate (linux) tasks.
Expected Behavior
Consistency between documentation and usable options reflected by synth/deployments in CDK.
Task is the one that is the only one actually supported.
Current Behavior
But using the host variant will results in:
Reproduction Steps
Possible Solution
Switch the checks from pidMode.HOST to pidMode.TASK.
Additional Information/Context
No response
CDK CLI Version
2.139.0
Framework Version
No response
Node.js Version
v20.12.0
OS
windows
Language
TypeScript
Language Version
No response
Other information
(OS is windows for where I ran CDK, the containers are linux as those are the only one allowing pidMode anyway)
The text was updated successfully, but these errors were encountered: