Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string validation for CloudFormation DashboardName #2976

Closed
cybergoof opened this issue Jun 20, 2019 · 3 comments · Fixed by #3382
Closed

Add string validation for CloudFormation DashboardName #2976

cybergoof opened this issue Jun 20, 2019 · 3 comments · Fixed by #3382
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch feature-request A feature should be added or improved.

Comments

@cybergoof
Copy link

cybergoof commented Jun 20, 2019

  • I'm submitting a ...
  • [ x ] 🚀 feature request
  • What is the current behavior?
    The "dashboardName" paramater for cloudwatch.Dashboard accepts a String, but on server side, CloudFormation will throw an error if the cloudwatch name has spaces
The value Doc Website Monitor for field DashboardName contains invalid characters. It can only contain alphanumerics, dash (-) and underscore (_). (Service: AmazonCloudWatch; Status Code: 400; Error Code: InvalidParameterValue; 

To reproduce:

  new cloudwatch.Dashboard(this, "FailedDashboard", { dashboardName: "Failed Dasboard"});
  • What is the expected behavior (or behaviour of feature suggested)?
    Add parameter validation in CDK

  • What is the motivation / use case for changing the behaviour or adding this feature?
    Identifies string errors at build time, rather than at CDK deploy

  • Please tell us about your environment:

    • CDK CLI Version: 0.34.0
    • Module Version: 0.34.0
    • OS: Ubuntu
    • Language: TypeScript
@made2591
Copy link
Contributor

I can fix this

@NGL321 NGL321 added @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch feature-request A feature should be added or improved. labels Jun 21, 2019
@NGL321
Copy link
Contributor

NGL321 commented Jun 21, 2019

@cybergoof Thank you for bringing this to our attention!

Unfortunately, we are working hard to stabilize the CDK APIs and tuning them to meet our consistency guidelines. While we work on getting the APIs aligned with our guidelines, we are pausing work on most community PRs and feature-requests starting today.
We expect to get back to work on community PRs within a few weeks.

That being said, @made2591 you are a rockstar! That would absolutely expedite the process. Feel free to self-assign this issue. We will get to any PRs submitted as soon as we can.

@made2591
Copy link
Contributor

thank @NGL321 ! then hope you will have fun in the next weeks 😃 you cannot imagine how much I would like to be there and partecipate to discussions with you guys 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants