Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-cloudformation bundles aws-sdk #2951

Closed
rix0rrr opened this issue Jun 20, 2019 · 6 comments · Fixed by #3027 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

aws-cloudformation bundles aws-sdk #2951

rix0rrr opened this issue Jun 20, 2019 · 6 comments · Fixed by #3027 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Assignees
@eladb
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 20, 2019

The AWS CloudFormation library depends on and bundles the aws-sdk library, just for some service metadata.

It should not do that.
@rix0rrr rix0rrr added bug This issue is a bug. @aws-cdk/aws-cloudformation Related to AWS CloudFormation labels Jun 20, 2019
@RomainMuller
Copy link
Contributor

Is that not just a dev-dependency?

@eladb
Copy link
Contributor

eladb commented Jun 20, 2019

This is worrying.

How about we introduce this as a separate experimental module? I am concerned that this is at the bottom of our dependency graph.

@jogold, FYI

@eladb eladb self-assigned this Jun 20, 2019
@eladb
Copy link
Contributor

eladb commented Jun 20, 2019

I am taking care of this.

@jogold
Copy link
Contributor

jogold commented Jun 20, 2019

The only reason why aws-sdk is declared as a dependency is to derive IAM statements from SDK service/actions:
https://github.com/awslabs/aws-cdk/blob/4f13e18172c677b3f34f1c51f64c50bb9f4b4e24/packages/%40aws-cdk/aws-cloudformation/lib/aws-custom-resource.ts#L182-L193

Alternatives:

  • find another way to map SDK service/actions to IAM statements
  • do not derive statements from SDK service/actions and force users to always add the proper statements to the AwsCustomResource construct

@eladb
Copy link
Contributor

eladb commented Jun 20, 2019

@jogold thanks for chiming in. This doesn't sound like the right tradeoff.

@eladb
Copy link
Contributor

eladb commented Jun 20, 2019

@jogold are you available for a quick chat on Gitter?

eladb pushed a commit that referenced this issue Jun 24, 2019
refactor(cloudformation): extract "customresources" module
e37a7fe 
Extract the AwsCustomResource construct to a separate module
called @aws-cdk/customresources, dedicated to special custom resources
such as this one.

Fixes #2951
@eladb eladb mentioned this issue Jun 24, 2019
Merged
eladb pushed a commit that referenced this issue Jun 24, 2019
refactor(cloudformation): extract "customresources" module
11692d4 
Extract the AwsCustomResource construct to a separate module
called @aws-cdk/customresources, dedicated to special custom resources
such as this one.

Fixes #2951
eladb pushed a commit that referenced this issue Jun 24, 2019
refactor(cloudformation): extract "custom-resources" module (#3027)
767687d 
Extract the AwsCustomResource construct to a separate module called @aws-cdk/custom-resources, dedicated to special custom resources such as this one.

Also, stop bundling the entire AWS SDK and instead extract `apis/metadata.json` during build time which fixes #2951.

BREAKING CHANGE: The `AwsCustomResource` class was moved to a new module called @aws-cdk/custom-resource
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
This was referenced Dec 13, 2019
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(cloudformation): extract "custom-resources" module aws/aws-cdk
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-cloudformation from 0.0.0 to 0.39.0 NOUIY/aws-solutions-constructs
4 participants
@RomainMuller @rix0rrr @eladb @jogold