Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon.CDK.AWS.Apigatewayv2.Integrations namespace still missing with 2.114.1. #28348

Closed
icelava opened this issue Dec 13, 2023 · 6 comments · Fixed by #30461
Closed

Amazon.CDK.AWS.Apigatewayv2.Integrations namespace still missing with 2.114.1. #28348

icelava opened this issue Dec 13, 2023 · 6 comments · Fixed by #30461
Assignees
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@icelava
Copy link

icelava commented Dec 13, 2023

Describe the bug

#28255 closed so reporting new one.

Apparently 2.114.0 is supposed to include the missing Amazon.CDK.AWS.Apigatewayv2 sub-modules and namespaces, but they are still regarded as non-existent by Visual Studio.

Expected Behavior

Amazon.CDK.AWS.Apigatewayv2.Integrations namespace (and HttpAlbIntegration) available from Amazon.CDK.Lib package.

Current Behavior

Amazon.CDK.AWS.Apigatewayv2.Integrations namespace does not exist.

Reproduction Steps

  • Update VS project to Amazon.CDK.Lib 2.114.1 (from 2.111.0).
  • Drop Amazon.CDK.AWS.APIGatewayv2.Alpha, Amazon.CDK.AWS.APIGatewayv2.Alpha.Integrations packages.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.111.0

Framework Version

.NET 6.0

Node.js Version

18.9.0

OS

Windows 11

Language

.NET

Language Version

C# 10

Other information

No response

@icelava icelava added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 13, 2023
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Dec 13, 2023
@pahud
Copy link
Contributor

pahud commented Dec 13, 2023

I was able to import that from VSCode with cdk 2.114.1

import { 
  aws_apigatewayv2 as apigwv2,
  aws_apigatewayv2_authorizers as apigwv2_authorizers,
  aws_apigatewayv2_integrations as apigwv2_integrations,
} from 'aws-cdk-lib';

export class DemoStack extends Stack {
  readonly fn: lambda.IFunction;
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const fn = lambda.Function.fromFunctionName(this, 'LambdaFunc', 'dummy');
    const defaultIntegration = new apigwv2_integrations.HttpLambdaIntegration('LambdaInteg', fn)
    new apigwv2.HttpApi(this, 'Api', {
      defaultIntegration,
    });

  }
}
% npx cdk --version
2.114.1 (build 02bbb1d)

@pahud pahud added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 13, 2023
@icelava
Copy link
Author

icelava commented Dec 14, 2023

It working for npm package does not mean it will work for NuGet package.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 14, 2023
@icelava
Copy link
Author

icelava commented Jan 9, 2024

Trying out 2.118.0 and still the namespace and classes are missing. Is anybody verifying the NuGet packages?

Amazon CDK AWS Apigatewayv2 Integrations missing

@icelava
Copy link
Author

icelava commented Jan 9, 2024

Ouch so it turns out the official Integrations module has been renamed to a very un-.NET namespace of Amazon.CDK.AwsApigatewayv2Integrations. I don't know why there's this sudden break from convention but at least some mention in the documentation would have been highly appreciated.

@ashishdhingra ashishdhingra self-assigned this Jun 3, 2024
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Jun 3, 2024

Issue appears to be reproducible in version 2.144.0:

  • For API Gateway v2 Integrations, looks like the new namespace is Amazon.CDK.AwsApigatewayv2Integrations instead of expected Amazon.CDK.AWS.Apigatewayv2.Integrations.
  • For API Gateway v2 Authorizers, looks like the new namespace is Amazon.CDK.AwsApigatewayv2Authorizers instead of expected Amazon.CDK.AWS.Apigatewayv2.Authorizers.

These namespaces should have followed consistent namespace after experimental construct was promoted to publicly supported L2 construct. My assumption is that this could be an issue with .NET package release process where it might have taken input from TypeScript packages aws-apigatewayv2-authorizers and aws-apigatewayv2-integrations, and might have simply concatenating the elements separated with -, in sentence case.

NOTE: This should be tested in other languages (like Java) as well.

Needs review with team.

@GavinZZ GavinZZ self-assigned this Jun 6, 2024
@mergify mergify bot closed this as completed in #30461 Jun 6, 2024
mergify bot pushed a commit that referenced this issue Jun 6, 2024
… jsiirc (#30461)

### Issue # (if applicable)

Closes #28348

### Reason for this change

When we promote apigatewayv2 from experimental to stable module, we did not add `jsiirc.json` file, thus no documentation is created and the namespace for import is incorrect. 

### Description of changes

We cannot fix the namespace now as this is stable modules and there're customers using it. Fixing this would be a breaking change to users who use apigatewayv2 in `aws-cdk-lib`.

### Description of how you validated changes

N/A

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

github-actions bot commented Jun 6, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this issue Jun 11, 2024
… jsiirc (aws#30461)

### Issue # (if applicable)

Closes aws#28348

### Reason for this change

When we promote apigatewayv2 from experimental to stable module, we did not add `jsiirc.json` file, thus no documentation is created and the namespace for import is incorrect. 

### Description of changes

We cannot fix the namespace now as this is stable modules and there're customers using it. Fixing this would be a breaking change to users who use apigatewayv2 in `aws-cdk-lib`.

### Description of how you validated changes

N/A

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this issue Jun 22, 2024
… jsiirc (aws#30461)

### Issue # (if applicable)

Closes aws#28348

### Reason for this change

When we promote apigatewayv2 from experimental to stable module, we did not add `jsiirc.json` file, thus no documentation is created and the namespace for import is incorrect. 

### Description of changes

We cannot fix the namespace now as this is stable modules and there're customers using it. Fixing this would be a breaking change to users who use apigatewayv2 in `aws-cdk-lib`.

### Description of how you validated changes

N/A

### Checklist
- [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants