aws-route53: (BREAKING!) Imported Route53 zone attribute and/or type mismatch

[einstein-aws]

Describe the bug

Seems like after the latest CDK update to v2.93.0 I am having trouble with importing Route53 hosted zones. I tried:

const route53Zone = r53.HostedZone.fromLookup(this, 'my-route53-zone', { domainName: 'mydomain.com' });

and...

const route53Zone = r53.PublicHostedZone.fromLookup(this, 'my-route53-zone', { domainName: 'mydomain.com' });

and...

const route53Zone = r53.HostedZone.fromHostedZoneAttributes(this, 'my-route53-zone', { zoneName: 'mydomain.com', hostedZoneId: 'my-zone-id' });

and...

const route53Zone = r53.PublicHostedZone.fromHostedZoneAttributes(this, 'my-route53-zone', { zoneName: 'mydomain.com', hostedZoneId: 'my-zone-id' });

and when I tried:

const sesIdentity = ses.Identity.publicHostedZone(route53Zone);

I am getting:

Argument of type 'IHostedZone' is not assignable to parameter of type 'IPublicHostedZone'.
  Property 'grantDelegation' is missing in type 'IHostedZone' but required in type 'IPublicHostedZone'.ts(2345)
hosted-zone.d.ts(146, 5): 'grantDelegation' is declared here.

Expected Behavior

Either of the above imports should work.

Current Behavior

Getting error:

Argument of type 'IHostedZone' is not assignable to parameter of type 'IPublicHostedZone'.
  Property 'grantDelegation' is missing in type 'IHostedZone' but required in type 'IPublicHostedZone'.ts(2345)
hosted-zone.d.ts(146, 5): 'grantDelegation' is declared here.

Reproduction Steps

Try to use either of the above Route53 zone imports in:

const sesIdentity = ses.Identity.publicHostedZone(route53Zone);

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

v2.93.0

Framework Version

No response

Node.js Version

v18.12.0

OS

MacOS Ventura 13.4.1

Language

Typescript

Language Version

No response

Other information

No response

[khushail]

Hi @einstein-aws , could you please share the complete code snippet for reproducing this issue? TIA.

[einstein-aws]

Hi @khushail. This is literally the code I am using. Here is the excerpt from my stack:

    // Lookup default Route53 public hosted zone
    // const appR53ZoneIdDefault = ssm.StringParameter.valueForStringParameter(this, appLabelR53ZoneIdDefault);
    // const appR53ZoneDefault = r53.PublicHostedZone.fromHostedZoneAttributes(this, appLabelR53Zone, { zoneName: appDomain, hostedZoneId: appR53ZoneIdDefault });
    const appR53Zone        = r53.HostedZone.fromLookup(this, appLabelR53Zone, { domainName: appDomain });
    const appR53SesIdentity = ses.Identity.publicHostedZone(appR53Zone); // <-- error is here

    // Define default SES identity
    const appSesIdentity = new ses.EmailIdentity(this, appLabelSesIdentity, {
      mailFromDomain              : `${appSubDomainMail}.${appDomain}`,
      configurationSet            : appSesConfigurationSet,
      identity                    : appR53SesIdentity,
      mailFromBehaviorOnMxFailure : ses.MailFromBehaviorOnMxFailure.REJECT_MESSAGE,
      dkimSigning                 : true,
      feedbackForwarding          : true
    });

[khushail]

Hi @einstein-aws , I used one of the import methods and tried to reproduce the issue but my code is succeeding. Please see here-

[einstein-aws]

I am getting the same error no matter what export method I use... Here is my version of your example:

Same problem. What else could it be? I have all my libraries updated (i.e. npm-check-updates).

[khushail]

@einstein-aws , the r53.HostedZone.fromLookup(this, appLabelR53Zone, ...) this appLabelR53Zone should be id , while it seems you have given some PublicHostedZone object here. Could you please check again and try giving it some string based id?

[einstein-aws]

@khushail It is a string, just a label. But, here is a hardcoded string:

...and here is import using fromHostedZoneId():

[khushail]

@einstein-aws , Yes, you are correct (my bad, forgot to check the version changes). This is a change in the latest version which was released yesterday. Looking at this PR, it looks like the changes in aws-route53 module caused this error.

Marking this issue as P2. Community PRs are welcome.

[einstein-aws]

@khushail Thank you! I hope this will be fixed soon :)

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.