aws-events-targets: KinesisFirehoseStream not accepting IDeliveryStream for imported DeliveryStream

[pags]

Describe the bug

When trying to add a KinesisFirehoseStream target to an event Rule, an error is thrown out of the aws-iam module.

Expected Behavior

CDK will successfully create an event rule with a target of an existing Kinesis Firehose stream.

Current Behavior

An error is thrown:

util_1.sum(values.map(v => (cdk.Token.isUnresolved(v) ? tokenSize : v.length) + 3 /* quotes, separator */));

TypeError: Cannot read properties of undefined (reading 'length')
    at @aws-cdk/aws-iam/lib/policy-statement.js:551:91

Reproduction Steps

new events.Rule(this, 'rule', {
			eventPattern: {
				source: ['aws.s3'],
				detail: {
					eventName: ['PutObject'],
					requestParameters: {
						bucketName: [bucket.bucketName]
					}
				}
			}
		}).addTarget(new targets.KinesisFirehoseStream(firehose.DeliveryStream.fromDeliveryStreamArn(this, 'firehose', 'my arn here'))); 

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.77.0 (build 06a0b19)

Framework Version

No response

Node.js Version

v16.14.2

OS

Ubuntu

Language

Typescript

Language Version

No response

Other information

No response

[pahud]

I believe this is because targets.KinesisFirehoseStream() is accepting CfnDeliveryStream as its parameter but fromDeliveryStreamArn actually returns IDeliveryStream instead.

I guess we probably need to allow KinesisFirehoseStream to accept the interface instead.

aws-cdk/packages/aws-cdk-lib/aws-events-targets/lib/kinesis-firehose-stream.ts

Line 26 in c3744ae

constructor(private readonly stream: firehose.CfnDeliveryStream, private readonly props: KinesisFirehoseStreamProps = {}) {

[pags]

Thank you for the insight, I am using JS (not TS) so did not have any type hints. Is there a prescribed way to get a CfnDeliveryStream instance based on what I have now?

[peterwoodworth]

Assuming you've created a deliverystream like so:

const stream = new firehose.DeliveryStream(this, 'Delivery Stream', {
  ...
});

You can access the CfnDeliveryStream like so with escape hatches

const cfnStream = stream.node.defaultChild

[peterwoodworth]

Sorry, you're importing it. If your DeliveryStream isn't managed by CloudFormation or CDK at all, you could cdk import the resource to be managed by your stack, and then the above comment could work. Else, if it's managed by CDK or another CloudFormation stack already and you want to keep it within that stack, I'm not sure there's a workaround here

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[Reiss-Cashmore]

Okay so I'm really struggling with a mismatch here:

I'm creating a DeliveryStream

import { CfnDeliveryStream } from 'aws-cdk-lib/aws-kinesisfirehose';


const firehoseStream = new CfnDeliveryStream(
      this,
      generateName('subscription-fulfillment-firehose-delivery-stream'),
      {
        deliveryStreamType: 'DirectPut',
        extendedS3DestinationConfiguration: {
          bucketArn: firehoseBucket.bucketArn,
          roleArn: firehoseRole.roleArn,
          bufferingHints: {
            sizeInMBs: 64,
            intervalInSeconds: 300,
          },
          s3BackupMode: 'Enabled',
          s3BackupConfiguration: {
            bucketArn: firehoseBucket.bucketArn,
            roleArn: firehoseRole.roleArn,
            compressionFormat: 'GZIP',
          },
          dataFormatConversionConfiguration: {
            enabled: true,
            inputFormatConfiguration: {
              deserializer: {
                openXJsonSerDe: {},
              },
            },
            outputFormatConfiguration: {
              serializer: {
                parquetSerDe: {},
              },
            },
            schemaConfiguration: {
              databaseName: glueDatabase.databaseName,
              tableName: glueTable.tableName,
              roleArn: firehoseRole.roleArn,
              region: this.region,
              versionId: 'LATEST',
            },
          },
          compressionFormat: 'UNCOMPRESSED',
          prefix: 'event/',       
            errorOutputPrefix: 'error/',
          dynamicPartitioningConfiguration: {
            enabled: true,
            retryOptions: {
              durationInSeconds: 300,
            },
          },
          processingConfiguration: {
            enabled: true,
            processors: [
              {
                type: 'MetadataExtraction',
                parameters: [
                ],
              },
            ],
          },
        },
      },
    );

Then I create a rule and try to add the DeliveryStream as a target. No matter what I try here I can't seem to resolve this. I can't use the L2 DeliveryStream construct because I need access to a lot of the configuration parameters as above.

import {
  Rule
} from 'aws-cdk-lib/aws-events';

 // Firehose specific rule
              const firehoseRule = new Rule(
                this,
                generateName(
                  `eventbus-firehose-rule-${Id}-${subIdx}`,
                ),
                {
                  eventBus,
                  eventPattern: {
                    source: ['test'],
                    detailType: ['test'],
                    detail: fullPattern,
                  },
                },
              );

              firehoseRule.addTarget(
                new targets.KinesisFirehoseStreamV2(firehoseStream, {
                  deadLetterQueue: subscriptionDLQ,
                  event: RuleTargetInput.fromObject({
                    inputPathsMap: {
                      -snip-
                    },
                    inputTemplate: `{
                      -snip-
                    }`
                  }),
                }),
              );
            },
          );

In your changes @pahud @atanaspam @GavinZZ did you mean to stop supporting CfnDeliveryStream as a type for this method. If so, how do I reconcile a CfnDeliveryStream to match an IDeliveryStream?