Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add dependsOn to container definitoin #2490

Closed
janaka opened this issue May 6, 2019 · 0 comments · Fixed by #3032
Closed

Unable to add dependsOn to container definitoin #2490

janaka opened this issue May 6, 2019 · 0 comments · Fixed by #3032
Labels
bug This issue is a bug.

Comments

@janaka
Copy link

janaka commented May 6, 2019

Given there is no App Mesh support yet I'm trying to use L1 constructs. Although not critical I guess, the docs instruct adding a dependsOn Envoy proxy container to the app container definition.

Problem 1: there is no cfnContainerDefinition. Therefore I cannot use addDependsOn()

Problem 2: as an alternative trying to use cfnTaskDefiniton_.AddOverride() as below but it appears this function does handle arrays. ContainerDefinitions is an array, therefore I cannot see how to add a dependsOn node.

https://github.com/awslabs/aws-cdk/blob/66dd2282bb6879aff803f80531fb4a1d324e97e7/packages/%40aws-cdk/cdk/lib/cfn-resource.ts#L158

My C# code

public static void AddDependsOnProxy(TaskDefinition TaskDefinition, string AppName)
{
      var cfnTaskDef = (CfnTaskDefinition_)TaskDefinition.Node.FindChild("Resource"); 

      string jsonstring = @"[{'containerName': 'envoy', 'condition': 'HEALTHY'}]";

      cfnTaskDef.AddOverride("Properties.ContainerDefinitions[0].dependsOn", jsonstring);
}
@janaka janaka added the bug This issue is a bug. label May 6, 2019
eladb pushed a commit that referenced this issue Aug 5, 2019
Add new addContainerDependencies method to allow for container dependencies
Fixes #2490
eladb pushed a commit that referenced this issue Aug 6, 2019
Add new addContainerDependencies method to allow for container dependencies
Fixes #2490
mergify bot pushed a commit that referenced this issue Aug 7, 2019
* chore: update package-lock.json

* feat(eks): define kubernetes resources

This change allows defining arbitrary Kubernetes resources within an EKS cluster.

* nice!

* update readme

* Update README.md

* feat(events): ability to add cross-account targets (#3323)

This adds the capability of adding a target to an event rule
that belongs to a different account than the rule itself.
Required for things like cross-account CodePipelines with source actions triggered by events.

* chore(ci): add mergify config file (#3502)

* chore: update jsii to 0.14.3 (#3513)

* fix(iam): correctly limit the default PolicyName to 128 characters (#3487)

Our logic for trimming the length of the default IAM policy name was not working,
as it wasn't updated when logicalId became a Token rather than a literate string,
and so it was never actually triggered
(it just checked that the display name of the Token was less than 128 characters,
which it always is).
The fix is to resolve the logical ID Token before applying the trimming logic.

Fixes #3402

* v1.3.0 (#3516)

See CHANGELOG

* fix: typo in restapi.ts (#3530)

* feat(ecs): container dependencies (#3032)

Add new addContainerDependencies method to allow for container dependencies
Fixes #2490

* feat(s3-deployment): CloudFront invalidation (#3213)

see #3106

* docs(core): findChild gets direct child only (#3512)

* doc(iam): update references to addManagedPolicy (#3511)

* fix(sqs): do not emit grants to the AWS-managed encryption key (#3169)

Grants on the `alias/aws/sqs` KMS key alias are not necessary since the
key will implicitly allow for it's intended usage to be fulfilled (as
opposed to how you have to manage grants yourself when using a
user-managed key instead).

This removes the statement that was generated using an invalid resource
entry.

Fixes #2794

* fix(lambda): allow ArnPrincipal in grantInvoke (#3501)

Fixes #3264 

I'm trying to allow a lambda function in another account to be able to invoke my CDK generated lambda function. This works through the CLI like so:

    aws lambda add-permission --function-name=myFunction --statement-id=ABoldStatement --action=lambda:InvokeFunction --principal=arn:aws:iam::{account_id}:role/a_lambda_execution_role

But CDK doesn't seem to allow me to add an ArnPrincipal doing something like this:

    myFunction.grantInvoke(new iam.ArnPrincipal(props.myARN))

With the error:

    Invalid principal type for Lambda permission statement: ArnPrincipal. Supported: AccountPrincipal, ServicePrincipal

This PR allows ArnPrincipal to be passed to lambda.grantInvoke.

There might be some additional validation required on the exact ARN as I believe only some ARNs are supported by lambda add-permission

* chore(contrib): remove API stabilization disclaimer

* fix(ssm): add GetParameters action to grantRead() (#3546)

* misc

* rename `KubernetesManifest` to `KubernetesResource` and `addResource`
* move AWS Auth APIs to `cluster.awsAuth` and expose `AwsAuth`
* remove the yaml library (we can just use a JSON stream)
* add support for adding accounts to aws-auth
* fix cluster deletion bug
* move kubctl app info to constants

* addManifest => addResource

* update test expectations

* add unit test for customresrouce.ref

* fix sample link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant