Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (rds): PostgreSQL engine version 15.2 #24462

Closed
1 of 2 tasks
klausbadelt opened this issue Mar 5, 2023 · 2 comments · Fixed by #24463
Closed
1 of 2 tasks

feat (rds): PostgreSQL engine version 15.2 #24462

klausbadelt opened this issue Mar 5, 2023 · 2 comments · Fixed by #24463
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@klausbadelt
Copy link
Contributor

klausbadelt commented Mar 5, 2023 •
edited
Loading

Describe the feature

RDS supports PostgreSQL engine version 15.2, but the PostgresEngineVersion.VER_15_2 constant is not implemented yet. The current CDK version only lists up to VER_14_6.

aws rds describe-db-engine-versions --engine postgres | jq -r '.DBEngineVersions[] | [.EngineVersion]' | grep "15\."
  "15.2"

Use Case

new DatabaseInstance(this, 'PostgresDatabase',  
  engine: DatabaseInstanceEngine.postgres({ version: PostgresEngineVersion.VER_15_2 }),
)

Proposed Solution

Add VER_15_2 to packages/@aws-cdk/aws-rds/lib/instance-engine.ts.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.67.0

Environment details (OS name and version, etc.)

macOS 13.2
@klausbadelt klausbadelt added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 5, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Mar 5, 2023
@klausbadelt klausbadelt mentioned this issue Mar 5, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Mar 6, 2023

This is awesome! Thank you for the PR!

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 6, 2023
@mergify mergify bot closed this as completed in #24463 Mar 9, 2023
mergify bot pushed a commit that referenced this issue Mar 9, 2023
@klausbadelt
feat(rds): PostgreSQL engine version 15.2 (#24463)
59d795b 
RDS supports PostgreSQL engine version 15.2, but the `PostgresEngineVersion.VER_15_2` constant  is not implemented yet. The current CDK version only lists up to `VER_14_6`.

```sh
aws rds describe-db-engine-versions --engine postgres | jq -r '.DBEngineVersions[] | [.EngineVersion]' | grep "15\."
  "15.2"
```

### Use Case

```js
new DatabaseInstance(this, 'PostgresDatabase',  
  engine: DatabaseInstanceEngine.postgres({ version: PostgresEngineVersion.VER_15_2 }),
)
```

Closes #24462.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
@klausbadelt @homakk
feat(rds): PostgreSQL engine version 15.2 (aws#24463)
b3c97f0 
RDS supports PostgreSQL engine version 15.2, but the `PostgresEngineVersion.VER_15_2` constant  is not implemented yet. The current CDK version only lists up to `VER_14_6`.

```sh
aws rds describe-db-engine-versions --engine postgres | jq -r '.DBEngineVersions[] | [.EngineVersion]' | grep "15\."
  "15.2"
```

### Use Case

```js
new DatabaseInstance(this, 'PostgresDatabase',  
  engine: DatabaseInstanceEngine.postgres({ version: PostgresEngineVersion.VER_15_2 }),
)
```

Closes aws#24462.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rds): PostgreSQL engine version 15.2 klausbadelt/aws-cdk
2 participants
@pahud @klausbadelt