Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli): Support notification-arns in cdk import #23548

Open
1 of 2 tasks
rdbatch opened this issue Jan 3, 2023 · 2 comments
Open
1 of 2 tasks

(cli): Support notification-arns in cdk import #23548

rdbatch opened this issue Jan 3, 2023 · 2 comments
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2 package/tools Related to AWS CDK Tools or CLI

Comments

@rdbatch
Copy link
Contributor

rdbatch commented Jan 3, 2023

Describe the feature

When using the cdk import command (aws/aws-cdk-rfcs#52), there doesn't appear to be a way to pass the --notification-arns flag as you can do in a normal deployment. Since an import operation creates a cloudformation change set and --notification-arns is already a valid flag on the cdk deploy command, it's reasonable to expect that this paramer could be passed for cdk import as well.

Use Case

When updating Cloudformation stacks, processes that trigger off Cloudformation notifications and need a way to be able to pass the SNS topic so they can react to import operations triggered via CDK.

Proposed Solution

Since --notification-arns is already present and supported on cdk deploy, this should be implemented the same way to that someone who is used to using that flag on the deploy command can apply it to cdk import as well. This would be an optional parameter so it shouldn't negatively impact any existing workflows.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.59.0 and 1.186.1

Environment details (OS name and version, etc.)

N/A - New Feature Request

@rdbatch rdbatch added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 3, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jan 3, 2023
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2023
@rix0rrr rix0rrr removed their assignment Jan 5, 2023
@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 5, 2023

Sounds good!

@naorpeled
Copy link

naorpeled commented Jan 9, 2023

@rix0rrr

Hey, may I be assigned to this task? 🙏

Coderzzzzzzzzzz added a commit to Coderzzzzzzzzzz/aws-cdk that referenced this issue May 12, 2023
Coderzzzzzzzzzz added a commit to Coderzzzzzzzzzz/aws-cdk that referenced this issue Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants