Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DashboardName missing in CloudWatch #192

Closed
rix0rrr opened this issue Jun 29, 2018 · 0 comments · Fixed by #194
Closed

Handle DashboardName missing in CloudWatch #192

rix0rrr opened this issue Jun 29, 2018 · 0 comments · Fixed by #194

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 29, 2018

CloudWatch Dashboards have a bug where they won't Update properly if the DashboardName is missing from the L1.

We should compensate for that issue in the CDK until the bug is fixed.

rix0rrr pushed a commit that referenced this issue Jun 29, 2018
- bugfix: label/color were ignored when passed directly to the Metric
  constructor.
- BREAKING CHANGE: ChangeMetricProps renamed to MetricCustomizations.
- change: onAlarm()/onOk() now take variadic arguments
- workaround: generate a dashboard name if user did not supply one.
  This fixes #192.
rix0rrr added a commit that referenced this issue Jul 2, 2018
- bugfix: label/color were ignored when passed directly to the Metric
  constructor.
- BREAKING CHANGE: ChangeMetricProps renamed to MetricCustomization.
- BREAKING CHANGE: removed public helper methods from Metric.
- change: onAlarm()/onOk() now take variadic arguments
- workaround: generate a dashboard name if user did not supply one.
  This fixes #192.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant