Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-redshift): Redshift construct is missing the elasticIp property #19191

Closed
rnsaway opened this issue Feb 28, 2022 · 2 comments · Fixed by #21085
Closed

(aws-redshift): Redshift construct is missing the elasticIp property #19191

rnsaway opened this issue Feb 28, 2022 · 2 comments · Fixed by #21085
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@rnsaway
Copy link

rnsaway commented Feb 28, 2022

What is the problem?

The aws-redshift-alpha cluster construct as spec'd here:

https://constructs.dev/packages/@aws-cdk/aws-redshift-alpha/v/2.14.0-alpha.0/api/Cluster?lang=typescript

is missing the elasticIp property on the CfnCluster resource.

Reproduction Steps

instantiate a new Cluster resource. elasticIp prop is missing.

What did you expect to happen?

the elasticIp property needs to be available or the construct is not able to associate an elastic IP.

What actually happened?

elasticIp property is missing.

CDK CLI Version

2.14

Framework Version

No response

Node.js Version

v16.14.0

OS

macOS

Language

Typescript

Language Version

No response

Other information

No response

@rnsaway rnsaway added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 28, 2022
@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Feb 28, 2022
@NGL321 NGL321 added feature-request A feature should be added or improved. feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs p1 in-progress This issue is being actively worked on. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 2, 2022
@NGL321
Copy link
Contributor

NGL321 commented Mar 2, 2022

Hey @rnsaway,

Since this is a missing feature in an experimental library, I have adjusted this to report as a feature-request with an implementation provided. This will help us prioritize your PR.

😸

@mergify mergify bot closed this as completed in #21085 Jul 18, 2022
mergify bot pushed a commit that referenced this issue Jul 18, 2022
Fixes #19191.

Adds the property `elasticIp` to the `ClusterProps`.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

comcalvi pushed a commit to comcalvi/aws-cdk that referenced this issue Jul 25, 2022
Fixes aws#19191.

Adds the property `elasticIp` to the `ClusterProps`.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants