-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-redshift): Redshift construct is missing the elasticIp property #19191
Comments
Hey @rnsaway, Since this is a missing feature in an experimental library, I have adjusted this to report as a feature-request with an implementation provided. This will help us prioritize your PR. 😸 |
Fixes #19191. Adds the property `elasticIp` to the `ClusterProps`. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Fixes aws#19191. Adds the property `elasticIp` to the `ClusterProps`. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
What is the problem?
The aws-redshift-alpha cluster construct as spec'd here:
https://constructs.dev/packages/@aws-cdk/aws-redshift-alpha/v/2.14.0-alpha.0/api/Cluster?lang=typescript
is missing the elasticIp property on the CfnCluster resource.
Reproduction Steps
instantiate a new Cluster resource. elasticIp prop is missing.
What did you expect to happen?
the elasticIp property needs to be available or the construct is not able to associate an elastic IP.
What actually happened?
elasticIp property is missing.
CDK CLI Version
2.14
Framework Version
No response
Node.js Version
v16.14.0
OS
macOS
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: