Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-cloudwatch): Saved queries #16395

Closed
2 tasks
ramonwilkinson opened this issue Sep 6, 2021 · 4 comments
Closed
2 tasks

(aws-cloudwatch): Saved queries #16395

ramonwilkinson opened this issue Sep 6, 2021 · 4 comments
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@ramonwilkinson
Copy link

Add the creation of Saved Queries for CloudWatch Log Insights.

Use Case

Allowing the creation of saved queries with CDK would encourage a software team to define common queries used across multiple accounts. In our team for example, we have separate AWS accounts for each region and stage of our product. Being able to deploy a saved query to many accounts and regions from infrastructure code would simplify the sharing process.

Proposed Solution

Feature request only - I'm not proposing a solution concept.

Other

N/A

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ramonwilkinson ramonwilkinson added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 6, 2021
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Sep 6, 2021
@awsiv
Copy link

awsiv commented Sep 24, 2021

Good idea!

Cloudformation support has recently been added:

aws-cloudformation/cloudformation-coverage-roadmap#615

@madeline-k
Copy link
Contributor

Thanks for opening this feature request, @ramonwilkinson! Until L2 CDK support is implemented for this feature, you can use the L1 construct to create saved queries in your CDK app: https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-logs.CfnQueryDefinition.html

@madeline-k madeline-k added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 24, 2021
@madeline-k madeline-k removed their assignment Nov 24, 2021
@jerry-shao jerry-shao mentioned this issue Jan 25, 2022
Merged
@jerry-shao
Copy link
Member

PR: #18655

mergify bot pushed a commit that referenced this issue Apr 20, 2022
@jerry-shao
feat(logs): add QueryDefinition L2 Construct (#18655)
fcf981b 
This PR implemented the [[feature request] (aws-cloudwatch): Saved queries](#16395). It will let users be able to create CloudWatch Logs Insights QueryDefinition by using L2 construct.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
@jerry-shao
feat(logs): add QueryDefinition L2 Construct (aws#18655)
ee237ad 
This PR implemented the [[feature request] (aws-cloudwatch): Saved queries](aws#16395). It will let users be able to create CloudWatch Logs Insights QueryDefinition by using L2 construct.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@awsiv @ramonwilkinson @jerry-shao @madeline-k