Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECS Deploy Action for Codepipeline #1386

Closed
aweiher opened this issue Dec 17, 2018 · 7 comments · Fixed by #2050 · May be fixed by MechanicalRock/account-reaper#6
Closed

Add ECS Deploy Action for Codepipeline #1386

aweiher opened this issue Dec 17, 2018 · 7 comments · Fixed by #2050 · May be fixed by MechanicalRock/account-reaper#6
Assignees
@skinny85
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline

Comments

@aweiher
Copy link
Contributor

aweiher commented Dec 17, 2018 •
edited
Loading

Codepipeline can deploy to ESC-Cluster. Package aws-ecs need connectors for codepipeline, like pipeline-actions.ts in aws-ecr, but extends from codepipeline-api.DeployAction.

Allowed Input Artifacts: 1 (image definition file)
Allowed Output Artifacts: 0

See (Action Type Constraints for Artifacts) for all codepipeline actions
@skinny85 skinny85 self-assigned this Dec 17, 2018
@skinny85 skinny85 added @aws-cdk/aws-codepipeline Related to AWS CodePipeline gap labels Dec 17, 2018
@aweiher
Copy link
Contributor Author

aweiher commented Dec 17, 2018

This screenshot shows how this will look in the aws console:
auswahl_059

@rix0rrr rix0rrr added gap and removed gap labels Jan 4, 2019
@madshargreave
Copy link

This would be awesome

@defel
Copy link

defel commented Jan 16, 2019

Hi,

I would like to start working on this one ✌️

@skinny85
Copy link
Contributor

@defel go right ahead :) And thanks!

@skinny85
Copy link
Contributor

skinny85 commented Mar 4, 2019

Hey @defel ,

any progress working on this?

Thanks,
Adam

@defel
Copy link

defel commented Mar 6, 2019

Hej, sorry for the delay. Yes, still working on this.

Had a blocker with extending ecs-cluster (addToPipeline). But just saw, that you have added new codepipeline.DeployAction helpers since january, which will help me.

Please give me a week more, will try to create a pull-request, thanks :)

@skinny85
Copy link
Contributor

skinny85 commented Mar 6, 2019

No worries, I was just checking in :). Thanks!

@defel defel mentioned this issue Mar 19, 2019
Closed
4 tasks
@aweiher aweiher mentioned this issue Mar 19, 2019
Merged
4 tasks
skinny85 pushed a commit to aweiher/aws-cdk that referenced this issue Apr 5, 2019
@aweiher @skinny85
feat(codepipeline): add ECS deploy Action.
2ad6372 
Fixes aws#1386
skinny85 pushed a commit to skinny85/aws-cdk that referenced this issue Apr 8, 2019
@aweiher @skinny85
feat(codepipeline): add ECS deploy Action.
7adc79e 
Fixes aws#1386
skinny85 pushed a commit to skinny85/aws-cdk that referenced this issue Apr 8, 2019
@aweiher @skinny85
feat(codepipeline): add ECS deploy Action.
657411f 
Fixes aws#1386
skinny85 pushed a commit that referenced this issue Apr 9, 2019
@aweiher @skinny85
feat(codepipeline): add ECS deploy Action. (#2050)
d46b814 
Fixes #1386
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline
Projects
None yet
Milestone
No milestone
5 participants
@defel @aweiher @skinny85 @rix0rrr @madshargreave