Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-cloudfront): EdgeFunction us-east-1 helper stack created in different account #12789

Closed
danilobuerger opened this issue Jan 30, 2021 · 1 comment · Fixed by #13055
Closed
Assignees
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@danilobuerger
Copy link
Contributor

When using a EdgeFunction inside a environment stack the us-east-1 helper stack is created in a different account (the one with the aws credentials)

Reproduction Steps

Use demo from https://docs.aws.amazon.com/cdk/api/latest/docs/aws-cloudfront-readme.html#lambdaedge
Created it inside environment stack (with account "A") and deploy with aws credentials of account "B".

What did you expect to happen?

us-east-1 helper stack should be deployed to account "A"

What actually happened?

us-east-1 helper stack is deployed to account "B"

Environment

  • CDK CLI Version : 1.85.0
  • Node.js Version: 15.4.0
  • Language (Version): TypeScript 4.1.3

This is 🐛 Bug Report

@danilobuerger danilobuerger added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 30, 2021
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Jan 30, 2021
njlynch added a commit that referenced this issue Feb 15, 2021
…count

The us-east-1 stack for EdgeFunction was defaulting to the default deploy
account. This means that using one account to deploy, and another for the stack
which contains the EdgeFunction, the support stack in us-east-1 will be deployed
into the deploy account, rather than stack account.

This fix has the us-east-1 stack inherit the account from the parent stack.

fixes #12789
@njlynch njlynch added effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2021
@mergify mergify bot closed this as completed in #13055 Feb 15, 2021
mergify bot pushed a commit that referenced this issue Feb 15, 2021
…count (#13055)

The us-east-1 stack for EdgeFunction was defaulting to the default deploy
account. This means that using one account to deploy, and another for the stack
which contains the EdgeFunction, the support stack in us-east-1 will be deployed
into the deploy account, rather than stack account.

This fix has the us-east-1 stack inherit the account from the parent stack.

fixes #12789


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

NovakGu pushed a commit to NovakGu/aws-cdk that referenced this issue Feb 18, 2021
…count (aws#13055)

The us-east-1 stack for EdgeFunction was defaulting to the default deploy
account. This means that using one account to deploy, and another for the stack
which contains the EdgeFunction, the support stack in us-east-1 will be deployed
into the deploy account, rather than stack account.

This fix has the us-east-1 stack inherit the account from the parent stack.

fixes aws#12789


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants