Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-lambda-python): Manage dependencies with Poetry #11753

Closed
2 tasks
Padwicker opened this issue Nov 27, 2020 · 2 comments · Fixed by #11850
Closed
2 tasks

(aws-lambda-python): Manage dependencies with Poetry #11753

Padwicker opened this issue Nov 27, 2020 · 2 comments · Fixed by #11850
Assignees
@eladb
Labels
@aws-cdk/aws-lambda-python

Comments

@Padwicker
Copy link

Are there any plans to support dependency management using Poetry in the same way that requirements.txt and Pipfile are?

Use Case

Poetry is a increasingly popular dependency management/packaging solution for Python and is arguably more user friendly than either pipenv or pip. It would be great if this method had direct support.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@setu4993 setu4993 mentioned this issue Dec 3, 2020
Merged
@setu4993
Copy link
Contributor

setu4993 commented Dec 3, 2020

I took a stab at this in #11850.

@mergify mergify bot closed this as completed in #11850 Dec 4, 2020
mergify bot pushed a commit that referenced this issue Dec 4, 2020
@setu4993
feat(lambda-python): support poetry packaging for PythonFunction (#11850
c5c258a 
)

This PR adds [poetry](https://python-poetry.org/) support to building Lambda dependencies for the PythonFunction.

I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something.

Closes #11753.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Dec 4, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

skiyani pushed a commit to skiyani/aws-cdk that referenced this issue Dec 7, 2020
@setu4993 @skiyani
feat(lambda-python): support poetry packaging for PythonFunction (aws…
d8ad0ae 
…#11850)

This PR adds [poetry](https://python-poetry.org/) support to building Lambda dependencies for the PythonFunction.

I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something.

Closes aws#11753.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@setu4993 @flochaz
feat(lambda-python): support poetry packaging for PythonFunction (aws…
8bcc34a 
…#11850)

This PR adds [poetry](https://python-poetry.org/) support to building Lambda dependencies for the PythonFunction.

I used the pipenv setup for inspiration. I'm not very familiar with writing integration tests, so there's a possibility that I could've missed something.

Closes aws#11753.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/aws-lambda-python
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lambda-python): support poetry packaging for PythonFunction setu4993/aws-cdk
3 participants
@eladb @setu4993 @Padwicker