Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@aws-cdk/aws-logs] Add KmsKeyId to LogGroup #11211

Closed
1 of 2 tasks
jamesholmes-linktree opened this issue Oct 30, 2020 · 1 comment · Fixed by #11363
Closed
1 of 2 tasks

[@aws-cdk/aws-logs] Add KmsKeyId to LogGroup #11211

jamesholmes-linktree opened this issue Oct 30, 2020 · 1 comment · Fixed by #11363
Assignees
@shivlaks
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p1

Comments

@jamesholmes-linktree
Copy link

Support for KMS encryption ion CloudWatch Log Groups

Use Case

Encrypting logs

Proposed Solution

Add the KmsKeyId property as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-logs-loggroup.html

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@jamesholmes-linktree jamesholmes-linktree added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2020
@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Oct 30, 2020
@nicklaw5 nicklaw5 mentioned this issue Nov 9, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Nov 9, 2020
@shivlaks shivlaks added p1 effort/small Small work item – less than a day of effort labels Nov 12, 2020
@mergify mergify bot closed this as completed in #11363 Nov 13, 2020
mergify bot pushed a commit that referenced this issue Nov 13, 2020
@nicklaw5
feat(logs): Add KMS key support to LogGroup (#11363)
21ccfce 
This PR updates the `LogGroup` construct to support the ability to encrypt log groups on creation.

Closes #11211

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(logs): Add KMS key support to LogGroup nicklaw5/aws-cdk
3 participants
@SomayaB @shivlaks @jamesholmes-linktree