fix(aws-ecs): Add type annotation for the workaround to missing import in d.ts file #1117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@aws-cdk/aws-ecs/lib/fargate/fargate-task-definition.d.ts
file was emitted wrong because TypeScript have an issue (microsoft/TypeScript#26969). So I think we have to workaround by adding a type annotation.Before
(Comments removed)
This emit an error like
../../node_modules/@aws-cdk/aws-ecs/lib/fargate/fargate-task-definition.d.ts(46,28): error TS2304: Cannot find name 'NetworkMode'.
After
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.