-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rds] Can't export the secret name from a DatabaseCluster #10914
Labels
@aws-cdk/aws-rds
Related to Amazon Relational Database
bug
This issue is a bug.
in-progress
This issue is being actively worked on.
Comments
ericzbeard
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Oct 16, 2020
github-actions
bot
added
the
@aws-cdk/aws-rds
Related to Amazon Relational Database
label
Oct 16, 2020
I'm experiencing this as well, I'm on CLI version 1.67. |
njlynch
added a commit
that referenced
this issue
Oct 29, 2020
For owned Secrets, `secretName` was set to the physical name, which was set to the provided `secretName` if given, or a Token otherwise. However, the Token was never resolved, as the `secretName` isn't actually a return vaue / attribute. The fix explicitly sets the `secretName` either to the inputted name or the parsed name from the ARN. Note that this means the secret name will be the partial/"friendly" name (e.g., 'MySecret') if the secret name was passed in, and the full name (e.g., 'MySecret-123abc') otherwise. fixes #10914
njlynch
added
in-progress
This issue is being actively worked on.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Oct 29, 2020
mergify bot
pushed a commit
that referenced
this issue
Nov 5, 2020
For owned Secrets, `secretName` was set to the physical name, which was set to the provided `secretName` if given, or a Token otherwise. However, the Token was never resolved, as the `secretName` isn't actually a return vaue / attribute. The fix explicitly sets the `secretName` either to the inputted name or the parsed name from the ARN. Note that this means the secret name will be the partial/"friendly" name (e.g., 'MySecret') if the secret name was passed in, and the full name (e.g., 'MySecret-123abc') otherwise. fixes #10914 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-rds
Related to Amazon Relational Database
bug
This issue is a bug.
in-progress
This issue is being actively worked on.
It is not possible to export the name of the secret that is generated by the DatabaseCluster construct.
Reproduction Steps
What did you expect to happen?
The secret name should be exported in the synthesized template.
What actually happened?
The resource in the template is missing the Value, which causes a deployment failure.
Environment
Other
We should also modify CfnOutput to fail when the value provided is undefined.
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: