Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeBuildProject to support custom role #10866

Closed
2 tasks
newcomer opened this issue Oct 14, 2020 · 2 comments · Fixed by #10865
Closed
2 tasks

CodeBuildProject to support custom role #10866

newcomer opened this issue Oct 14, 2020 · 2 comments · Fixed by #10865
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@newcomer
Copy link
Contributor

This is a 🚀 Feature Request

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

CDK creates new role and its policy when creating event rule for code build project. We already have custom role, so we would like to specify it when defining CodeBuildProject.

Proposed Solution

Add ability to specify custom role for CodeBuildProject (similar to #3999)
@newcomer newcomer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2020
@newcomer newcomer changed the title [module] CodeBuildProject to support custom role Oct 14, 2020
@newcomer newcomer mentioned this issue Oct 14, 2020
Merged
@newcomer
Copy link
Contributor Author

PR for this enhancement: #10865

Currently, fails on linting https://github.com/aws/aws-cdk/pull/10865/checks?check_run_id=1252476038:
Error: Features must contain a change to a README file
Haven't found any guidance on this in https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md

@newcomer newcomer mentioned this issue Oct 14, 2020
Closed
2 tasks
newcomer added a commit to newcomer/aws-cdk that referenced this issue Oct 14, 2020
@newcomer
feat(events): allow passing a role to the CodeBuild target
3243baa 
Fixes aws#10866
@mergify mergify bot closed this as completed in #10865 Oct 14, 2020
mergify bot pushed a commit that referenced this issue Oct 14, 2020
@newcomer
feat(events-targets): allow passing a role to the CodeBuild target (#…
f085a09 
…10865)

fixes #10866

----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(events-targets): allow passing a role to the CodeBuild target newcomer/aws-cdk
1 participant
@newcomer