Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cfnspec): cloudformation spec v18.5.0 #10636

Merged
merged 3 commits into from
Oct 2, 2020
Merged

feat(cfnspec): cloudformation spec v18.5.0 #10636

merged 3 commits into from
Oct 2, 2020

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented Oct 1, 2020 •
edited
Loading

No description provided.

@shivlaks shivlaks self-assigned this Oct 1, 2020
@shivlaks shivlaks mentioned this pull request Oct 1, 2020
Closed
@shivlaks
Copy link
Contributor

shivlaks commented Oct 1, 2020

PR currently failing as AWS::StepFunctions::Activity has had a property that has been deleted - Name

failure message

Argument of type '{ name: string; }' is not assignable to parameter of type 'CfnActivityProps'.
@aws-cdk/aws-stepfunctions:   Object literal may only specify known properties, and 'name' does not exist in type 'CfnActivityProps'.

getting in touch with the Step Functions team to sort out next steps.

PatMyron
PatMyron reviewed Oct 1, 2020
View reviewed changes
packages/@aws-cdk/cfnspec/CHANGELOG.md
Comment on lines +16 to +17
* AWS::StepFunctions::Activity Name (__deleted__)
* AWS::StepFunctions::Activity Arn (__added__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws-cloudformation/cfn-lint#1715 (comment)
aws-cloudformation/cfn-lint#1722

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @PatMyron!! - I've applied the same patch to our commit

@shivlaks shivlaks added the pr-linter/exempt-test The PR linter will not require test changes label Oct 1, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7398cc4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e99cf63 into master Oct 2, 2020
@mergify mergify bot deleted the bump-cfnspec/v18.5.0 branch October 2, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatMyron PatMyron PatMyron left review comments

@shivlaks shivlaks shivlaks approved these changes

Assignees

@shivlaks shivlaks

Labels
pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aws-cdk-automation @shivlaks @PatMyron