Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudFormation Resource Specification 18.5.0 #1715

Merged
merged 1 commit into from
Sep 27, 2020
Merged

CloudFormation Resource Specification 18.5.0 #1715

merged 1 commit into from
Sep 27, 2020

Conversation

kddejong
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Update specs to 18.5.0
scripts/update_specs_from_pricing.py # requires Boto3 and Credentials
scripts/update_specs_services_from_ssm.py # requires Boto3 and Credentials
cfn-lint --update-specs # https://github.com/aws-cloudformation/cfn-python-lint/pull/1383\#issuecomment-629891506
cfn-lint --update-iam-policies
cfn-lint --update-documentation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PatMyron
PatMyron reviewed Sep 27, 2020
View reviewed changes
scripts/update_specs_from_pricing.py
Comment on lines +44 to +47
'US East (Verizon) - Atlanta': 'us-east-1',
'US East (Verizon) - Boston': 'us-east-1',
'US East (Verizon) - New York': 'us-east-1',
'US East (Verizon) - Washington DC': 'us-east-1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://aws.amazon.com/about-aws/whats-new/2020/09/announcing-new-aws-wavelength-zones-in-atlanta-new-york-city-washington-dc/

@PatMyron PatMyron changed the title Update specs to 18.5.0 CloudFormation Resource Specification 18.5.0 Sep 27, 2020
@kddejong kddejong merged commit 2159b51 into aws-cloudformation:master Sep 27, 2020
@kddejong kddejong deleted the update/specs/18.5.0 branch September 27, 2020 16:13
PatMyron
PatMyron reviewed Sep 29, 2020
View reviewed changes
src/cfnlint/data/CloudSpecs/us-east-1.json
Comment on lines -68959 to +69128
"Name": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-stepfunctions-activity.html#cfn-stepfunctions-activity-name",
"Arn": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-stepfunctions-activity.html#cfn-stepfunctions-activity-arn",
"PrimitiveType": "String",
"Required": true,
"UpdateType": "Immutable"
"Required": false,
"UpdateType": "Mutable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrectly marking non-readOnlyProperties as readOnlyProperties for GetAtt compatibility during Registry migration seems to have lost AWS::StepFunctions::Activity.Name

@PatMyron PatMyron added the spec CloudFormation Specification Bug label Sep 29, 2020
This was referenced Sep 29, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatMyron PatMyron PatMyron approved these changes

Assignees
No one assigned
Labels
spec CloudFormation Specification Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kddejong @PatMyron