Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chatbot] Support setting log retention and expose metric methods in SlackChannelConfiguration #10135

Closed
1 of 2 tasks
humanzz opened this issue Sep 2, 2020 · 0 comments · Fixed by #10137
Closed
1 of 2 tasks
Assignees
Labels
@aws-cdk/aws-chatbot Related to AWS Chatbot feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@humanzz
Copy link
Contributor

humanzz commented Sep 2, 2020

With the recent changes to LogRetention construct in #9671 and #9703 and the creation of SlackChannelConfiguration construct in #9679, this is a follow up to request that SlackChannelConfiguration exposes log retention property and metric utility methods (similar to Lambda function)

Use Case

  1. Set log retention on the slack channel configuration log that lives in a different region
  2. Access slack channel configuration metrics easily

Proposed Solution

Inspired by the implementation in Lambda function

  1. Add props for log retention
  2. Add metric and metricAll methods

Other

Associate #8636

SlackChannelConfiguration is different from Lambda in that it is a global service writing cloudwatch logs/metrics to us-east-1 regardless of the region of the stack they live in.

I wanted to expose a logGroup() method similar to lambda but the current implementation for importing the log group from arn returns an ILogGroup which implements methods e.g. addStream, addMetricFilter which I think assume the log is in the same region so might introduce bugs.

I'm interested to hear your thoughts on this.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@humanzz humanzz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 2, 2020
@github-actions github-actions bot added the @aws-cdk/aws-chatbot Related to AWS Chatbot label Sep 2, 2020
@mergify mergify bot closed this as completed in #10137 Sep 4, 2020
mergify bot pushed a commit that referenced this issue Sep 4, 2020
)


Closes #10135


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-chatbot Related to AWS Chatbot feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants