Skip to content

Commit

Permalink
chore: update nodejs to 20 in devcontainer and gitpod (#30424)
Browse files Browse the repository at this point in the history
### Reason for this change

The contribution guide recommend the active node LTS: https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#getting-started

### Description of changes

Update node 18 to 20 in devcontainer and gitpod and also the os version to bookworm

### Description of how you validated changes

opened devcontainer and gitpod,  checkd the node version and run command `npx lerna run build --scope=aws-cdk-lib --scope=@aws-cdk-testing/framework-integ --skip-nx-cache`

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

refs:

- #25381
- #25426

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
JohannesKonings authored Jun 4, 2024
1 parent a3d9b10 commit f937100
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM jsii/superchain:1-buster-slim-node18
FROM jsii/superchain:1-bookworm-slim-node20

USER root

Expand Down
2 changes: 1 addition & 1 deletion .gitpod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ github:
pullRequestsFromForks: true
addComment: true

image: public.ecr.aws/jsii/superchain:1-buster-slim-node18
image: public.ecr.aws/jsii/superchain:1-bookworm-slim-node20

tasks:
- init: |
Expand Down

0 comments on commit f937100

Please sign in to comment.