fic(ecs): fix fromClusterAttributes (#2649)

Remove unnecessary import call. Fixes #2631.
aws · May 28, 2019 · f4817b1 · f4817b1
1 parent e6a9f9e
commit f4817b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/@aws-cdk/aws-ecs/lib/cluster.ts b/packages/@aws-cdk/aws-ecs/lib/cluster.ts
@@ -394,7 +394,7 @@ class ImportedCluster extends Construct implements ICluster {
   constructor(scope: Construct, id: string, props: ClusterAttributes) {
     super(scope, id);
     this.clusterName = props.clusterName;
-    this.vpc = ec2.Vpc.fromVpcAttributes(this, "vpc", props.vpc);
+    this.vpc = props.vpc;
     this.hasEc2Capacity = props.hasEc2Capacity !== false;
     this._defaultNamespace = props.defaultNamespace;
 

diff --git a/packages/@aws-cdk/aws-ecs/test/test.ecs-cluster.ts b/packages/@aws-cdk/aws-ecs/test/test.ecs-cluster.ts
@@ -364,6 +364,9 @@ export = {
     test.equal(cluster2.defaultNamespace!.type, cloudmap.NamespaceType.DnsPrivate);
     test.deepEqual(stack2.node.resolve(cluster2.defaultNamespace!.namespaceId), 'import-namespace-id');
 
+    // Can retrieve subnets from VPC - will throw 'There are no 'Private' subnets in this VPC. Use a different VPC subnet selection.' if broken.
+    cluster2.vpc.selectSubnets();
+
     test.done();
   }
 };