-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Loading status checks…
feat(efs): allow to specify az for one-zone (#30010)
### Issue # (if applicable) This PR allows users to specify AZ for the one-zone filesystems through the `vpcSubnets.availabilityZones`. Before this PR, `vpcSubnets` is not allowed when `oneZone` is enabled, this PR removes the restriction and takes the following use cases into considerations: - [x] create a regional EFS file system with a mount target for each AZ - [x] create a one-zone EFS file system with mount target at the auto-selected AZ - [x] create a one-zone EFS file system at specified AZ with a single mount target at that AZ - [x] create a regional EFS file system with a single mount target at the specified AZ Closes #30005 ### Reason for this change ### Description of changes ### Description of how you validated changes 1. Add additional unit tests. 2. I have deployed the code below and validated from my AWS console. ```ts // create a regional EFS file system with a mount target for each AZ new FileSystem(stack, 'FileSystem1', { vpc, }); // create a one-zone EFS file system with mount target at the auto-selected AZ new FileSystem(stack, 'FileSystem2', { vpc, oneZone: true, }); // create a one-zone EFS file system at specified AZ with a single mount target at that AZ new FileSystem(stack, 'FileSystem3', { vpc, oneZone: true, vpcSubnets: { availabilityZones: [vpc.availabilityZones[1]], }, }); // create a regional EFS file system with a single mount target at the specified AZ new FileSystem(stack, 'FileSystem4', { vpc, vpcSubnets: { availabilityZones: [vpc.availabilityZones[2]], }, }); ``` ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- v2.178.2
- v2.178.1
- v2.178.0
- v2.177.0
- v2.176.0
- v2.175.1
- v2.175.0
- v2.174.1
- v2.174.0
- v2.173.4
- v2.173.3
- v2.173.2
- v2.173.1
- v2.173.0
- v2.172.0
- v2.171.1
- v2.171.0
- v2.170.0
- v2.169.0
- v2.168.0
- v2.167.2
- v2.167.1
- v2.167.0
- v2.166.0
- v2.165.0
- v2.164.1
- v2.164.0
- v2.163.1
- v2.163.0
- v2.162.1
- v2.162.0
- v2.161.1
- v2.161.0
- v2.160.0
- v2.159.1
- v2.159.0
- v2.158.0
- v2.157.0
- v2.156.0
- v2.155.0
- v2.154.1
- v2.154.0
- v2.153.0
- v2.152.0
- v2.151.1
- v2.151.0
- v2.150.0
- v2.149.0
- v2.148.1
- v2.148.0
- v2.147.3
- v2.147.2
- v2.147.1
- v2.147.0
- v2.146.0
- v2.145.0
- v2.144.0
- v2.143.1
- v2.143.0
- v2.142.1
- v2.142.0
- v2.141.0
- v2.140.0
Showing
11 changed files
with
607 additions
and
263 deletions.
There are no files selected for viewing
147 changes: 0 additions & 147 deletions
147
.../asset.4554b47be6f57b68c6c7a7391dcc73894866d2377fe174883351e7639097f292/__entrypoint__.js
This file was deleted.
Oops, something went wrong.
155 changes: 155 additions & 0 deletions
155
.../asset.bde7b5c89cb43285f884c94f0b9e17cdb0f5eb5345005114dd60342e0b8a85a1/__entrypoint__.js
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
File renamed without changes.
20 changes: 19 additions & 1 deletion
20
...framework-integ/test/aws-efs/test/integ.efs-filesystem-one-zone.js.snapshot/manifest.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
10 changes: 5 additions & 5 deletions
10
...ws-efs/test/integ.efs-filesystem-one-zone.js.snapshot/test-efs-one-zone-integ.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
325 changes: 225 additions & 100 deletions
325
...ing/framework-integ/test/aws-efs/test/integ.efs-filesystem-one-zone.js.snapshot/tree.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters