fix build error

aws · Feb 24, 2020 · bee67c6 · bee67c6
1 parent e786f9f
commit bee67c6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 10 deletions.
diff --git a/packages/@aws-cdk/aws-ecs/lib/ec2/ec2-service.ts b/packages/@aws-cdk/aws-ecs/lib/ec2/ec2-service.ts
@@ -98,12 +98,16 @@ export interface Ec2ServiceAttributes {
   readonly cluster: ICluster;
   /**
    * The service ARN.
+   *
+   * @default - generated from serviceName
    */
-  readonly serviceArn: string?;
+  readonly serviceArn?: string;
   /**
    * The name of the service.
+   *
+   * @default - generated from serviceArn
    */
-  readonly serviceName: string?;
+  readonly serviceName?: string;
 }
 
 /**
@@ -132,9 +136,10 @@ export class Ec2Service extends BaseService implements IEc2Service {
       throw new Error('You can only specify either serviceArn or serviceName.');
     }
     const stack = Stack.of(scope);
-    let name, arn: string;
+    let name: string;
+    let arn: string;
     if (attrs.serviceName) {
-      name = attrs.serviceName;
+      name = attrs.serviceName as string;
       arn = stack.formatArn({
         partition: stack.partition,
         service: 'ecs',
@@ -144,7 +149,7 @@ export class Ec2Service extends BaseService implements IEc2Service {
         resourceName: name,
       });
     } else {
-      arn = attrs.serviceArn;
+      arn = attrs.serviceArn as string;
       name = stack.parseArn(arn).resourceName as string;
     }
     class Import extends Resource implements IBaseService {

diff --git a/packages/@aws-cdk/aws-ecs/lib/fargate/fargate-service.ts b/packages/@aws-cdk/aws-ecs/lib/fargate/fargate-service.ts
@@ -76,12 +76,16 @@ export interface FargateServiceAttributes {
   readonly cluster: ICluster;
   /**
    * The service ARN.
+   *
+   * @default - generated from serviceName
    */
-  readonly serviceArn: string?;
+  readonly serviceArn?: string;
   /**
    * The name of the service.
+   *
+   * @default - generated from serviceArn
    */
-  readonly serviceName: string?;
+  readonly serviceName?: string;
 }
 
 /**
@@ -110,9 +114,10 @@ export class FargateService extends BaseService implements IFargateService {
       throw new Error('You can only specify either serviceArn or serviceName.');
     }
     const stack = cdk.Stack.of(scope);
-    let name, arn: string;
+    let name: string;
+    let arn: string;
     if (attrs.serviceName) {
-      name = attrs.serviceName;
+      name = attrs.serviceName as string;
       arn = stack.formatArn({
         partition: stack.partition,
         service: 'ecs',
@@ -122,7 +127,7 @@ export class FargateService extends BaseService implements IFargateService {
         resourceName: name,
       });
     } else {
-      arn = attrs.serviceArn;
+      arn = attrs.serviceArn as string;
       name = stack.parseArn(arn).resourceName as string;
     }
     class Import extends cdk.Resource implements IBaseService {