chore(ecs): add additional missing unit tests (#3679)

* Add additional missing unit tests * Update on aug 19 feedbacks * Indentations and minor change
aws · Aug 19, 2019 · 98f131a · 98f131a
1 parent f21d950
commit 98f131a
Show file tree

Hide file tree

Showing 9 changed files with 1,630 additions and 69 deletions.
diff --git a/packages/@aws-cdk/aws-ecs/lib/container-definition.ts b/packages/@aws-cdk/aws-ecs/lib/container-definition.ts
@@ -323,6 +323,11 @@ export class ContainerDefinition extends cdk.Construct {
    */
   constructor(scope: cdk.Construct, id: string, private readonly props: ContainerDefinitionProps) {
     super(scope, id);
+    if (props.memoryLimitMiB !== undefined && props.memoryReservationMiB !== undefined) {
+      if (props.memoryLimitMiB < props.memoryReservationMiB) {
+        throw new Error(`MemoryLimitMiB should not be less than MemoryReservationMiB.`);
+      }
+    }
     this.essential = props.essential !== undefined ? props.essential : true;
     this.taskDefinition = props.taskDefinition;
     this.memoryLimitSpecified = props.memoryLimitMiB !== undefined || props.memoryReservationMiB !== undefined;

diff --git a/packages/@aws-cdk/aws-ecs/lib/ec2/ec2-service.ts b/packages/@aws-cdk/aws-ecs/lib/ec2/ec2-service.ts
@@ -190,7 +190,7 @@ export class Ec2Service extends BaseService implements IEc2Service, elb.ILoadBal
       throw new Error("Cannot use a Classic Load Balancer if NetworkMode is Bridge. Use Host or AwsVpc instead.");
     }
     if (this.taskDefinition.networkMode === NetworkMode.NONE) {
-      throw new Error("Cannot use a load balancer if NetworkMode is None. Use Host or AwsVpc instead.");
+      throw new Error("Cannot use a Classic Load Balancer if NetworkMode is None. Use Host or AwsVpc instead.");
     }
 
     this.loadBalancers.push({