Skip to content

Commit

Permalink
feat(custom-resources): include handler log group in error messages (#…
Browse files Browse the repository at this point in the history
…8839)

Adds the CloudWatch log group name to error messages emitted by user handlers so it's easier to go find additional information.

Additionally, added descriptions to the provider framework lambda functions so they are easier to identify.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
Elad Ben-Israel authored Jul 2, 2020
1 parent 4326f24 commit 8e055d4
Show file tree
Hide file tree
Showing 6 changed files with 526 additions and 385 deletions.
40 changes: 20 additions & 20 deletions packages/@aws-cdk/aws-dynamodb/test/integ.global.expected.json
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
},
"/",
{
"Ref": "AssetParametersb83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3eS3Bucket09EBFB87"
"Ref": "AssetParameters51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620eS3Bucket58C634A6"
},
"/",
{
Expand All @@ -241,7 +241,7 @@
"Fn::Split": [
"||",
{
"Ref": "AssetParametersb83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3eS3VersionKey46B9F32F"
"Ref": "AssetParameters51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620eS3VersionKeyE8ACA4C1"
}
]
}
Expand All @@ -254,7 +254,7 @@
"Fn::Split": [
"||",
{
"Ref": "AssetParametersb83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3eS3VersionKey46B9F32F"
"Ref": "AssetParameters51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620eS3VersionKeyE8ACA4C1"
}
]
}
Expand All @@ -270,11 +270,11 @@
"referencetocdkdynamodbglobal20191121AssetParameters23c5f8cc1bdef276fc20dbb166d24d1b7d8cb516a5d5822ed0d38feec9631fd1S3VersionKey849A4FA5Ref": {
"Ref": "AssetParameters23c5f8cc1bdef276fc20dbb166d24d1b7d8cb516a5d5822ed0d38feec9631fd1S3VersionKeyC7F72494"
},
"referencetocdkdynamodbglobal20191121AssetParameters5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6S3Bucket14A4D0F4Ref": {
"Ref": "AssetParameters5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6S3Bucket03CDDE18"
"referencetocdkdynamodbglobal20191121AssetParameters956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3S3Bucket80086951Ref": {
"Ref": "AssetParameters956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3S3Bucket0EEA1C2E"
},
"referencetocdkdynamodbglobal20191121AssetParameters5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6S3VersionKeyF9E42BF5Ref": {
"Ref": "AssetParameters5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6S3VersionKey68B2E471"
"referencetocdkdynamodbglobal20191121AssetParameters956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3S3VersionKeyC3096D21Ref": {
"Ref": "AssetParameters956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3S3VersionKey7BCE18C9"
}
}
}
Expand All @@ -293,29 +293,29 @@
"Type": "String",
"Description": "Artifact hash for asset \"23c5f8cc1bdef276fc20dbb166d24d1b7d8cb516a5d5822ed0d38feec9631fd1\""
},
"AssetParameters5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6S3Bucket03CDDE18": {
"AssetParameters956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3S3Bucket0EEA1C2E": {
"Type": "String",
"Description": "S3 bucket for asset \"5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6\""
"Description": "S3 bucket for asset \"956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3\""
},
"AssetParameters5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6S3VersionKey68B2E471": {
"AssetParameters956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3S3VersionKey7BCE18C9": {
"Type": "String",
"Description": "S3 key for asset version \"5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6\""
"Description": "S3 key for asset version \"956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3\""
},
"AssetParameters5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6ArtifactHash3651BF53": {
"AssetParameters956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3ArtifactHash2CBB11D2": {
"Type": "String",
"Description": "Artifact hash for asset \"5d5280180ad87e8a1c2a08423cb5b2dae41281832799cd51db5eff913091ade6\""
"Description": "Artifact hash for asset \"956c2f92ddbde06f551fdf914445c679dcadb21c6e8d1ee9c9632144ef5a2ad3\""
},
"AssetParametersb83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3eS3Bucket09EBFB87": {
"AssetParameters51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620eS3Bucket58C634A6": {
"Type": "String",
"Description": "S3 bucket for asset \"b83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3e\""
"Description": "S3 bucket for asset \"51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620e\""
},
"AssetParametersb83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3eS3VersionKey46B9F32F": {
"AssetParameters51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620eS3VersionKeyE8ACA4C1": {
"Type": "String",
"Description": "S3 key for asset version \"b83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3e\""
"Description": "S3 key for asset version \"51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620e\""
},
"AssetParametersb83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3eArtifactHash55859AF2": {
"AssetParameters51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620eArtifactHashDF827F41": {
"Type": "String",
"Description": "Artifact hash for asset \"b83a25851fe809a45e4920961bf8456cf216e425943d42aaba01916e2f868a3e\""
"Description": "Artifact hash for asset \"51ac5fed1b824803906219cb11f0c17572739bd4fb019d961cdc1fbbfefc620e\""
}
}
}
}
Loading

0 comments on commit 8e055d4

Please sign in to comment.