Merge branch 'main' into madeline-k/remove-cognito-cfnspec-patch

aws · Jul 7, 2022 · 7b48adb · 7b48adb
2 parents 1b33c1d + e43e4f2
commit 7b48adb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/@aws-cdk/aws-sns/lib/topic-base.ts b/packages/@aws-cdk/aws-sns/lib/topic-base.ts
@@ -35,7 +35,7 @@ export interface ITopic extends IResource, notifications.INotificationRuleTarget
   /**
    * Subscribe some endpoint to this topic
    */
-  addSubscription(subscription: ITopicSubscription): void;
+  addSubscription(subscription: ITopicSubscription): Subscription;
 
   /**
    * Adds a statement to the IAM resource policy associated with this topic.
@@ -80,7 +80,7 @@ export abstract class TopicBase extends Resource implements ITopic {
   /**
    * Subscribe some endpoint to this topic
    */
-  public addSubscription(subscription: ITopicSubscription) {
+  public addSubscription(subscription: ITopicSubscription): Subscription {
     const subscriptionConfig = subscription.bind(this);
 
     const scope = subscriptionConfig.subscriberScope || this;
@@ -95,7 +95,7 @@ export abstract class TopicBase extends Resource implements ITopic {
       throw new Error(`A subscription with id "${id}" already exists under the scope ${scope.node.path}`);
     }
 
-    new Subscription(scope, id, {
+    return new Subscription(scope, id, {
       topic: this,
       ...subscriptionConfig,
     });