add comment explaining why Names.uniqueId() is retained

aws · Dec 19, 2023 · 4850d82 · 4850d82
1 parent f284e7c
commit 4850d82
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/packages/aws-cdk-lib/aws-iam/lib/private/imported-role.ts b/packages/aws-cdk-lib/aws-iam/lib/private/imported-role.ts
@@ -46,6 +46,8 @@ export class ImportedRole extends Resource implements IRole, IComparablePrincipa
   public addToPrincipalPolicy(statement: PolicyStatement): AddToPrincipalPolicyResult {
     if (!this.defaultPolicy) {
       const useUniqueName = FeatureFlags.of(this).isEnabled(IAM_IMPORTED_ROLE_STACK_SAFE_DEFAULT_POLICY_NAME);
+      // To preserve existing policy names, use Names.uniqueResourceName() only when exceeding the limit of policy names
+      // See https://github.com/aws/aws-cdk/pull/27548 for more
       const prefix = 'Policy';
       let defaultDefaultPolicyName = useUniqueName
         ? `${prefix}${Names.uniqueId(this)}`