-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(core): convert "/" in construct id to "--" and disallow tokens
Relax construct ID constraints to allow "/" (path seprator) to be used in construct IDs, but convert it to "--" so it won't collide with path strings. It's quite rare for people to actually try to find a construct by their ID (it's mostly "write-only") and the logical ID is eventually mangled anyway when synthesized to CFN. Fails if the construct ID contains a token. This won't work because we mangle the IDs as strings when we generate the logical ID and the construct's unique ID, and stringified tokens won't be resolved. Fixes #1351 Fixes #1374
- Loading branch information
Elad Ben-Israel
committed
Dec 17, 2018
1 parent
9cebf0d
commit 2461582
Showing
6 changed files
with
83 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters