Check if url is unresolved

aws · Jun 20, 2019 · 11929e2 · 11929e2
1 parent 651d5a0
commit 11929e2
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/@aws-cdk/aws-sns-subscriptions/lib/url.ts b/packages/@aws-cdk/aws-sns-subscriptions/lib/url.ts
@@ -1,5 +1,5 @@
 import sns = require('@aws-cdk/aws-sns');
-import { Construct } from '@aws-cdk/cdk';
+import { Construct, Token } from '@aws-cdk/cdk';
 
 /**
  * Options for URL subscriptions.
@@ -24,10 +24,13 @@ export interface UrlSubscriptionProps {
  */
 export class UrlSubscription implements sns.ITopicSubscription {
   constructor(private readonly url: string, private readonly protocol: sns.SubscriptionProtocol, private readonly props: UrlSubscriptionProps = {}) {
+    if (!Token.isUnresolved(url)) {
+      throw new Error(`url: ${url} must be resolved`);
+    }
   }
 
   public bind(scope: Construct, topic: sns.ITopic): void {
-    new sns.Subscription(scope, this.url, {
+    new sns.Subscription(scope, topic.node.uniqueId + 'Url', {
       topic,
       endpoint: this.url,
       protocol: this.protocol,