Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
Elad Ben-Israel committed Nov 3, 2020
1 parent a1df324 commit 1057ed4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ abstract class CloudFormationDeployAction extends CloudFormationAction {
// pass role is not allowed for cross-account access - so,
// create the deployment Role in the other account!
this._deploymentRole = new iam.Role(roleStack,
`${cdk.Names.uniqueId(stage.pipeline)}-${stage.stageName}-${this.actionProperties.actionName}-DeploymentRole`, {
`${cdk.Names.nodeUniqueId(stage.pipeline.node)}-${stage.stageName}-${this.actionProperties.actionName}-DeploymentRole`, {
assumedBy: new iam.ServicePrincipal('cloudformation.amazonaws.com'),
roleName: cdk.PhysicalName.GENERATE_IF_NEEDED,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export class CodeCommitSourceAction extends Action {
}

private generateEventId(stage: codepipeline.IStage): string {
const baseId = Names.uniqueId(stage.pipeline);
const baseId = Names.nodeUniqueId(stage.pipeline.node);
if (Token.isUnresolved(this.branch)) {
let candidate = '';
let counter = 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class EcrSourceAction extends Action {
resources: [this.props.repository.repositoryArn],
}));

this.props.repository.onCloudTrailImagePushed(Names.uniqueId(stage.pipeline) + 'SourceEventRule', {
this.props.repository.onCloudTrailImagePushed(Names.nodeUniqueId(stage.pipeline.node) + 'SourceEventRule', {
target: new targets.CodePipeline(stage.pipeline),
imageTag: this.props.imageTag,
});
Expand Down

0 comments on commit 1057ed4

Please sign in to comment.