Skip to content

Commit

Permalink
chore: turn on awslint in alpha modules (#27901)
Browse files Browse the repository at this point in the history
This stops the bleeding. I did not audit the linter exemptions at all :(, and there are some that are clearly wrong. Like `no-unused-type`, if it's unused it probably was a mistake to be exposed in the module at all. But alas, I spent no time auditing the rules

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
kaizencc authored Nov 9, 2023
1 parent 550105a commit 0695599
Show file tree
Hide file tree
Showing 29 changed files with 205 additions and 87 deletions.
15 changes: 11 additions & 4 deletions packages/@aws-cdk/aws-apprunner-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"attribute-tag:@aws-cdk/aws-apprunner-alpha.Service.serviceName",
"docs-public-apis:@aws-cdk/aws-apprunner-alpha.HealthCheck.healthCheckProtocolType",
"docs-public-apis:@aws-cdk/aws-apprunner-alpha.HealthCheck.healthyThreshold",
"docs-public-apis:@aws-cdk/aws-apprunner-alpha.HealthCheck.interval",
"docs-public-apis:@aws-cdk/aws-apprunner-alpha.HealthCheck.timeout",
"docs-public-apis:@aws-cdk/aws-apprunner-alpha.HealthCheck.unhealthyThreshold",
"docs-public-apis:@aws-cdk/aws-apprunner-alpha.HealthCheck.path",
"docs-public-apis:@aws-cdk/aws-apprunner-alpha.HealthCheck.bind"
]
}
10 changes: 6 additions & 4 deletions packages/@aws-cdk/aws-cloud9-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-physical-name:@aws-cdk/aws-cloud9-alpha.Ec2EnvironmentProps",
"docs-public-apis:@aws-cdk/aws-cloud9-alpha.CloneRepository.pathComponent",
"docs-public-apis:@aws-cdk/aws-cloud9-alpha.CloneRepository.repositoryUrl"
]
}
8 changes: 4 additions & 4 deletions packages/@aws-cdk/aws-codestar-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-physical-name:@aws-cdk/aws-codestar-alpha.GitHubRepositoryProps"
]
}
8 changes: 4 additions & 4 deletions packages/@aws-cdk/aws-cognito-identitypool-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-physical-name:@aws-cdk/aws-cognito-identitypool-alpha.IdentityPoolRoleAttachmentProps"
]
}
12 changes: 8 additions & 4 deletions packages/@aws-cdk/aws-gamelift-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"docs-public-apis:@aws-cdk/aws-gamelift-alpha.OperatingSystem.AMAZON_LINUX",
"docs-public-apis:@aws-cdk/aws-gamelift-alpha.OperatingSystem.AMAZON_LINUX_2",
"docs-public-apis:@aws-cdk/aws-gamelift-alpha.OperatingSystem.WINDOWS_2012",
"docs-public-apis:@aws-cdk/aws-gamelift-alpha.Protocol.TCP",
"docs-public-apis:@aws-cdk/aws-gamelift-alpha.Protocol.UDP"
]
}
68 changes: 64 additions & 4 deletions packages/@aws-cdk/aws-glue-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,65 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"construct-ctor-props-type:@aws-cdk/aws-glue-alpha.Table",
"props-physical-name:@aws-cdk/aws-glue-alpha.DataQualityRulesetProps",
"events-method-signature:@aws-cdk/aws-glue-alpha.Job.onStateChange",
"no-unused-type:@aws-cdk/aws-glue-alpha.StorageParameters",
"no-unused-type:@aws-cdk/aws-glue-alpha.TableProps",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ClassificationString.AVRO",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ClassificationString.CSV",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ClassificationString.JSON",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ClassificationString.ORC",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ClassificationString.PARQUET",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ClassificationString.XML",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ClassificationString.value",
"docs-public-apis:@aws-cdk/aws-glue-alpha.DataQualityRuleset.fromRulesetArn",
"docs-public-apis:@aws-cdk/aws-glue-alpha.DataQualityRuleset.fromRulesetName",
"docs-public-apis:@aws-cdk/aws-glue-alpha.Database.fromDatabaseArn",
"docs-public-apis:@aws-cdk/aws-glue-alpha.InputFormat.className",
"docs-public-apis:@aws-cdk/aws-glue-alpha.OutputFormat.className",
"docs-public-apis:@aws-cdk/aws-glue-alpha.Schema",
"docs-public-apis:@aws-cdk/aws-glue-alpha.Schema.BINARY",
"docs-public-apis:@aws-cdk/aws-glue-alpha.Schema.BOOLEAN",
"docs-public-apis:@aws-cdk/aws-glue-alpha.Schema.DOUBLE",
"docs-public-apis:@aws-cdk/aws-glue-alpha.Schema.FLOAT",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.AVRO",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.CLOUDTRAIL",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.GROK",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.HIVE_JSON",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.LAZY_SIMPLE",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.OPEN_CSV",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.OPENX_JSON",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.ORC",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.PARQUET",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.REGEXP",
"docs-public-apis:@aws-cdk/aws-glue-alpha.SerializationLibrary.className",
"docs-public-apis:@aws-cdk/aws-glue-alpha.StorageParameter.key",
"docs-public-apis:@aws-cdk/aws-glue-alpha.StorageParameter.value",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBase.tableArn",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBase.tableName",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBase.partitionIndexes",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBase.fromTableArn",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBase.grantRead",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBase.grantReadWrite",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBase.grantWrite",
"props-default-doc:@aws-cdk/aws-glue-alpha.DataQualityRulesetProps.clientToken",
"props-default-doc:@aws-cdk/aws-glue-alpha.DataQualityRulesetProps.description",
"docs-public-apis:@aws-cdk/aws-glue-alpha.DatabaseProps",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ExternalTableProps",
"docs-public-apis:@aws-cdk/aws-glue-alpha.IDataQualityRuleset",
"docs-public-apis:@aws-cdk/aws-glue-alpha.IDatabase",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ITable",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ITable.tableArn",
"docs-public-apis:@aws-cdk/aws-glue-alpha.ITable.tableName",
"props-default-doc:@aws-cdk/aws-glue-alpha.PythonRayExecutableProps.runtime",
"props-default-doc:@aws-cdk/aws-glue-alpha.PythonShellExecutableProps.runtime",
"props-default-doc:@aws-cdk/aws-glue-alpha.PythonSparkJobExecutableProps.runtime",
"docs-public-apis:@aws-cdk/aws-glue-alpha.S3TableProps",
"props-default-doc:@aws-cdk/aws-glue-alpha.ScalaJobExecutableProps.runtime",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableAttributes",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableAttributes.tableArn",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableAttributes.tableName",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableBaseProps",
"docs-public-apis:@aws-cdk/aws-glue-alpha.TableProps"
]
}
12 changes: 8 additions & 4 deletions packages/@aws-cdk/aws-iot-actions-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"docs-public-apis:@aws-cdk/aws-iot-actions-alpha.HttpActionHeader",
"docs-public-apis:@aws-cdk/aws-iot-actions-alpha.HttpActionSigV4Auth",
"props-default-doc:@aws-cdk/aws-iot-actions-alpha.HttpsActionProps.auth",
"props-default-doc:@aws-cdk/aws-iot-actions-alpha.HttpsActionProps.confirmationUrl",
"props-default-doc:@aws-cdk/aws-iot-actions-alpha.HttpsActionProps.headers"
]
}
8 changes: 4 additions & 4 deletions packages/@aws-cdk/aws-iot-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"no-unused-type:@aws-cdk/aws-iot-alpha.ActionConfig"
]
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-iotevents-actions-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
9 changes: 5 additions & 4 deletions packages/@aws-cdk/aws-iotevents-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"no-unused-type:@aws-cdk/aws-iotevents-alpha.ActionBindOptions",
"no-unused-type:@aws-cdk/aws-iotevents-alpha.ActionConfig"
]
}
10 changes: 6 additions & 4 deletions packages/@aws-cdk/aws-ivs-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-physical-name:@aws-cdk/aws-ivs-alpha.StreamKeyProps",
"from-method:@aws-cdk/aws-ivs-alpha.PlaybackKeyPair",
"from-method:@aws-cdk/aws-ivs-alpha.StreamKey"
]
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"no-unused-type:@aws-cdk/aws-kinesisanalytics-flink-alpha.PropertyGroups"
]
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-kinesisfirehose-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-lambda-go-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-lambda-python-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-location-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-location-alpha/lib/place-index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export enum DataSource {
*
* @see https://docs.aws.amazon.com/location/latest/developerguide/HERE.html
*/
HERE = 'Here'
HERE = 'Here',
}

/**
Expand All @@ -86,7 +86,7 @@ export enum IntendedUse {
/**
* The result can be cached or stored in a database
*/
STORAGE = 'Storage'
STORAGE = 'Storage',
}

abstract class PlaceIndexBase extends Resource implements IPlaceIndex {
Expand Down
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-msk-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
11 changes: 7 additions & 4 deletions packages/@aws-cdk/aws-neptune-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-physical-name:@aws-cdk/aws-neptune-alpha.ClusterParameterGroupProps",
"props-physical-name:@aws-cdk/aws-neptune-alpha.ParameterGroupProps",
"props-physical-name:@aws-cdk/aws-neptune-alpha.SubnetGroupProps",
"docs-public-apis:@aws-cdk/aws-neptune-alpha.ServerlessScalingConfiguration"
]
}
12 changes: 8 additions & 4 deletions packages/@aws-cdk/aws-redshift-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-physical-name:@aws-cdk/aws-redshift-alpha.ClusterParameterGroupProps",
"props-physical-name:@aws-cdk/aws-redshift-alpha.ClusterSubnetGroupProps",
"props-physical-name:@aws-cdk/aws-redshift-alpha.DatabaseSecretProps",
"attribute-tag:@aws-cdk/aws-redshift-alpha.DatabaseSecret.secretName",
"attribute-tag:@aws-cdk/aws-redshift-alpha.DatabaseSecret.secretFullArn"
]
}
10 changes: 6 additions & 4 deletions packages/@aws-cdk/aws-route53resolver-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-physical-name:@aws-cdk/aws-route53resolver-alpha.FirewallDomainListProps",
"props-physical-name:@aws-cdk/aws-route53resolver-alpha.FirewallRuleGroupProps",
"props-physical-name:@aws-cdk/aws-route53resolver-alpha.FirewallRuleGroupAssociationProps"
]
}
8 changes: 4 additions & 4 deletions packages/@aws-cdk/aws-s3objectlambda-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"attribute-tag:@aws-cdk/aws-s3objectlambda-alpha.AccessPoint.accessPointName"
]
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-sagemaker-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
26 changes: 22 additions & 4 deletions packages/@aws-cdk/aws-scheduler-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"construct-ctor-props-optional:@aws-cdk/aws-scheduler-alpha.Group",
"props-physical-name:@aws-cdk/aws-scheduler-alpha.GroupProps",
"from-method:@aws-cdk/aws-scheduler-alpha.Schedule",
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleArn",
"attribute-tag:@aws-cdk/aws-scheduler-alpha.Schedule.scheduleName",
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.ContextAttribute.name",
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.Group",
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.GroupProps",
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.IGroup",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleProps.targetOverrides",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.deadLetterConfig",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.ecsParameters",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.eventBridgeParameters",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.input",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.kinesisParameters",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.retryPolicy",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.sageMakerPipelineParameters",
"props-default-doc:@aws-cdk/aws-scheduler-alpha.ScheduleTargetConfig.sqsParameters",
"docs-public-apis:@aws-cdk/aws-scheduler-alpha.ScheduleTargetProps"
]
}
1 change: 0 additions & 1 deletion packages/@aws-cdk/aws-scheduler-targets-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"exclude": [
"*:*"
]
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"construct-ctor:@aws-cdk/aws-servicecatalogappregistry-alpha.ApplicationAssociator.<initializer>.params[0]"
]
}
20 changes: 16 additions & 4 deletions packages/@aws-cdk/cli-lib-alpha/awslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
{
"exclude": [
"*:*"
]
}
"exclude": [
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.bootstrapCustomerKey",
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.bootstrapKmsKeyId",
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.customPermissionsBoundary",
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.examplePermissionsBoundary",
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.publicAccessBlockConfiguration",
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.qualifier",
"props-default-doc:@aws-cdk/cli-lib-alpha.BootstrapOptions.template",
"props-default-doc:@aws-cdk/cli-lib-alpha.BootstrapOptions.toolkitStackName",
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.trust",
"props-no-undefined-default:@aws-cdk/cli-lib-alpha.BootstrapOptions.trustForLookup",
"docs-public-apis:@aws-cdk/cli-lib-alpha.DeployOptions.hotswap",
"props-default-doc:@aws-cdk/cli-lib-alpha.DeployOptions.hotswap",
"docs-public-apis:@aws-cdk/cli-lib-alpha.HotswapMode"
]
}
Loading

0 comments on commit 0695599

Please sign in to comment.