RFC 460: Reduce aws-cdk-lib Package Size #430
Conversation
madeline-k
changed the title
…about future size of Lambda Layers to it's own FAQ
It is not as important to include this anymore now that we are focusing on the potential future size of all the lambda layer zips. The size of each individual file has no bearing on the solution.
…il in breaking change question
text/0039-reduce-module-size.md
Outdated
| class from the packages in step 1. We will need to do something clever here | ||
| to make sure customers do not have IDE or compilation errors before the CDK | ||
| CLI has an opportunity to download and install the lambda layer packages. | ||
| 3. Modify the CDK CLI to verify that the correct packages are available in the |
There was a problem hiding this comment.
Do we have any idea how will we implement that? Can we use optional dependencies?
There was a problem hiding this comment.
I still need to work on a POC to see how this will actually be implemented. Thanks for the optional dependencies suggestion, that looks like it would work. I will dive deeper and then update this section!
There was a problem hiding this comment.
I've tested this with the POC jsii library, and if we add a package as an optional dependency, then the following happens:
- The optional dependency is not included in the jsii packaged bundle for npm or PyPI
- When you run
npm installin a node project that lists the jsii library as a dependency, then the optional dependency is automatically installed as well. - You can run
npm install --no-optionalto avoid installing the optional dependencies - This has no impact on the experience for target languages (python).
So, this would only impact TS/JS users. The argument for using optional dependencies is that this could make it easier for TS/JS users, because the optional dependencies would be installed by default. The argument against is that TS/JS users will need to change their current workflow to avoid installing things they don't need. At first, I don't think we should include this. Let's wait to see if there are real customer issues that this would alleviate.
|
This RFC is now in the final comments period. It will be merged by next week. |
|
PR Lint is failing because of a different RFC document |
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
madeline-k
changed the title
Rendered Version
This is a request for comments about Reduce aws-cdk-lib Package Size. See #460 for
additional details.
APIs are signed off by @otaviomacedo.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license