-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 324: Construct Hub #314
Conversation
a12960c
to
04a9707
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was missing the discussion about Construct Hub as a construct.
Specifically we should discuss in advance:
- Monitoring
- Input streams
- Showing both public & internal modules
from packages found via other package search tools or registries, such as | ||
npmjs.com, Maven Central, PyPI, NuGet, etc. | ||
|
||
## Specification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RomainMuller, I think we need to expand this section with an exact list of features we plan to deliver for each page (and also ideally some form of a roadmap for future versions). @addihorowitz has most of this documented internally, but it should be part of this document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason it's important is that this will help us make sure the design actually covers all the required features
…nce of the file is dealt with
@RomainMuller what's the status here? Can we announce final comments period? |
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license