Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 324: Construct Hub #314

Merged
merged 29 commits into from
Jun 10, 2021
Merged

RFC 324: Construct Hub #314

merged 29 commits into from
Jun 10, 2021

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Apr 13, 2021


By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

@RomainMuller RomainMuller self-assigned this Apr 13, 2021
@RomainMuller RomainMuller force-pushed the rmuller/cdk-construct-hub branch from a12960c to 04a9707 Compare April 13, 2021 14:05
@RomainMuller RomainMuller marked this pull request as draft April 13, 2021 14:06
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments.

text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was missing the discussion about Construct Hub as a construct.

Specifically we should discuss in advance:

  • Monitoring
  • Input streams
  • Showing both public & internal modules

@RomainMuller RomainMuller marked this pull request as ready for review April 19, 2021 14:13
@eladb eladb changed the title feat: CDK construct hub feat: Construct Hub May 25, 2021
@eladb eladb changed the title feat: Construct Hub RFC: Construct Hub May 25, 2021
@RomainMuller RomainMuller mentioned this pull request May 25, 2021
@RomainMuller RomainMuller changed the title RFC: Construct Hub RFC 324: Construct Hub May 25, 2021
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
from packages found via other package search tools or registries, such as
npmjs.com, Maven Central, PyPI, NuGet, etc.

## Specification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomainMuller, I think we need to expand this section with an exact list of features we plan to deliver for each page (and also ideally some form of a roadmap for future versions). @addihorowitz has most of this documented internally, but it should be part of this document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason it's important is that this will help us make sure the design actually covers all the required features

text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Show resolved Hide resolved
text/0314-cdk-construct-hub.md Outdated Show resolved Hide resolved
@eladb
Copy link
Contributor

eladb commented Jun 6, 2021

@RomainMuller what's the status here? Can we announce final comments period?

@RomainMuller RomainMuller merged commit 9bf7dc8 into master Jun 10, 2021
@RomainMuller RomainMuller deleted the rmuller/cdk-construct-hub branch June 10, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants