Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check required crds #686

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add check required crds #686

wants to merge 1 commit into from

Conversation

u-kai
Copy link

@u-kai u-kai commented Jan 1, 2025

What type of PR is this?
Feature

Which issue does this PR fix:
#660

What does this PR do / Why do we need it:
This PR adds a feature that pre-checks the required CRDs for the controller.
If the required CRDs are not installed, the controller will fail fast.

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

Tested by deploying the changes in my EKS cluster.
If the required CRDs are not installed, the controller logs the following message:

{"level":"info","ts":"2025-01-01T04:23:53.272Z","caller":"workspace/main.go:161","msg":"log level set to debug"}
...
{"level":"info","ts":"2025-01-01T04:23:53.272Z","logger":"setup","caller":"runtime/proc.go:272","msg":"Webhook is enabled, 'webhook-cert' secret must contain a valid TLS key and cert"}
{"level":"fatal","ts":"2025-01-01T04:23:53.376Z","logger":"setup","caller":"runtime/proc.go:272","msg":"required CRDs check failed:missing required CRDs: gateway.networking.k8s.io/v1, Kind=Gateway, gateway.networking.k8s.io/v1, Kind=GatewayClass, gateway.networking.k8s.io/v1, Kind=HTTPRoute, gateway.networking.k8s.io/v1, Kind=GRPCRoute, gateway.networking.k8s.io/v1alpha2, Kind=TLSRoute"}

Automation added to e2e:

No
Will this PR introduce any new dependencies?:

No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@u-kai u-kai marked this pull request as ready for review January 1, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant