Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Which issue does this PR fix:
#638
What does this PR do / Why do we need it:
Updates the controller to use the v1.2.0 gateway API. GRPCRoutes must be upgraded from v1alpha2. This change will enable running the controller within environments using the gateway v1.1+ API. Apologies for the large diff, due to versioning issues I wasn't able to split it up at all.
Does not (should not) include any logic updates. Changes include:
DOES NOT include documentation updates. This will be done as a separate PR. Recommend next controller release to be
v1.1.0
given it's not a direct upgrade. Note that, like most CRD version upgrades, touching an object will advance it to the latest API version. This means other resources touched by the controller (e.g. HTTPRoute) will automatically be upgraded to v1 from beta versions.Recommended upgrade steps (from controller v1.0.X):
v1alpha2
version, can also just update GRPCRoute CRDTesting done on this change:
Ran e2e tests. Ran docker build. Created and eyeballed Helm chart.
Manual tests involved:
Automation added to e2e:
No additional tests
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
I have tested updating a running cluster with the above process.
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.