Improve github-release.sh #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijun726911
force-pushed
the
improve-github-release-script
branch
from
d652bb4 to
325f4d7
Compare
solmonk
reviewed
Jan 19, 2024
scripts/lib/common.sh
Outdated
| @@ -49,9 +49,11 @@ function sed_inplace() { | |||
|
|
|||
| if [[ "$OSTYPE" == "darwin"* ]]; then | |||
| # macOS uses BSD sed | |||
| echo "sed -i '' \"s|$pattern|$replacement|g\" \"$file\"" | |||
There was a problem hiding this comment.
you might want to look into something like set -x instead
There was a problem hiding this comment.
ok, let me remove it, I think people are free to add set -x by themself when debugging
solmonk
approved these changes
Jan 19, 2024
solmonk
pushed a commit
to solmonk/aws-application-networking-k8s
that referenced
this pull request
Jan 31, 2024
* Improve github-release.sh * Address PRs comments --------- Co-authored-by: Zijun Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve github-release.sh, delete local release branch/ tag if it exist, show error message if release branch/ tag exists remotely
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.