Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests and examples to be compatible w/ latest CRDs #515

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

solmonk
Copy link
Contributor

@solmonk solmonk commented Nov 17, 2023

What type of PR is this?

bug

Which issue does this PR fix:

Partially - #469

What does this PR do / Why do we need it:

Changed behavior for empty matches in rules. They had default value in the past but they don't right now.
https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io%2fv1.HTTPRouteRule
https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io/v1alpha2.GRPCRouteRule

Fixed our examples to be compatible with latest GWAPI CRDs.

  • HTTPRoute/GRPCRoute - All Service backendRefs require ports
  • Gateway - HTTPS listeners must have TLS section
  • Gateway - TLS section must include at least one cert when mode is Terminate
    • This is a tricky part, I had to add dummy fields on our examples. It looks ugly but probably okay.
  • Gateway - Listeners must be unique on name/port/hostname

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:
make e2e-test all pass

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@xWink xWink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these issues!

@solmonk solmonk merged commit 42cbb61 into aws:main Nov 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants