Added Auto-Generated API Reference #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijun726911
approved these changes
Nov 16, 2023
| export CLUSTER_VPC_ID ?= $(shell aws eks describe-cluster --name $(CLUSTER_NAME) | jq -r ".cluster.resourcesVpcConfig.vpcId") | ||
| export AWS_ACCOUNT_ID ?= $(shell aws sts get-caller-identity --query Account --output text) | ||
| export REGION ?= $(shell aws configure get region) | ||
| endif |
There was a problem hiding this comment.
Seems we can also put IMG, VERSION, ECRIMAGES in this if block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
docs/api-reference.mddocs/referencetodocs/api-typesto be more consistent with Gateway API directory format (and this naming makes more sense)api-referencetarget in Makefile to do the auto-generationhelptargetmake helpto take a long timemake helpchanging the env is a weird behaviour that people likely don't expect