add IAM Auth Policy dummy controller #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6569276151
💛 - Coveralls |
zijun726911
approved these changes
Oct 19, 2023
zijun726911
reviewed
Oct 19, 2023
| client: mgr.GetClient(), | ||
| } | ||
| err := ctrl.NewControllerManagedBy(mgr). | ||
| For(&anv1alpha1.IAMAuthPolicy{}). |
There was a problem hiding this comment.
You could add the pkg_builder.WithPredicates(predicate.GenerationChangedPredicate{}) in the later PRs
There was a problem hiding this comment.
GenerationChangedPredicate description is a bit vague to me. Especially "Caveats" section. Why do we use this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Add dummy controller for IAM Auth Policy. Policy can be attached to Lattice Service Network or Service. We support only Gateway, HTTP and GRPC routes as target references right now. I will split reconciliation into Gateway and Route types.
Partly #18