fix: create lattice resources when no endpoints in K8s services (#386) #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solmonk
approved these changes
Sep 20, 2023
| @@ -96,6 +97,11 @@ func (s *defaultTargetsManager) Create(ctx context.Context, targets *latticemode | |||
| targetList = append(targetList, &t) | |||
| } | |||
|
|
|||
| if len(targetList) == 0 { | |||
| glog.Warningln("There are no available targets to regiser. Skipping targets registration") | |||
There was a problem hiding this comment.
IMO I don't think we need this log line
zijun726911
reviewed
Sep 20, 2023
| It("Create lattice resources successfully when no Targets available", func() { | ||
| httpRoute = testFramework.NewHttpRoute(testGateway, service, "Service") | ||
|
|
||
| // Override port |
There was a problem hiding this comment.
Do you need to add more comments here to say that you override the httproute port to cause no port match so that it will cause no Targets in the TG? Or use a more explicit way to construct a no targetPort k8sService?
There was a problem hiding this comment.
I can add more comments. I doubt creating "no targetPort" K8s service will be used in other place so it will be over-kill to create a method to do that.
zijun726911
approved these changes
Sep 20, 2023
Pull Request Test Coverage Report for Build 6253438117
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
#386
What does this PR do / Why do we need it:
This PR allows the controller to continue to create Lattice service, and listeners, and rules when there are no targets to register
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:
Added unit tests, and e2e tests.
make e2e-testoutput:Automation added to e2e:
Added test case
httproute_creation_test.goWill this PR introduce any new dependencies?: No
Will this break upgrades or downgrades. Has updating a running cluster been tested?: No
Does this PR introduce any user-facing change?: No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.