Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove aws-sdk override, lattice service now available #320

Merged
merged 1 commit into from
Aug 10, 2023
Merged

remove aws-sdk override, lattice service now available #320

merged 1 commit into from
Aug 10, 2023

Conversation

mikhail-aws
Copy link
Contributor

@mikhail-aws mikhail-aws commented Aug 10, 2023 •
edited
Loading

Note:
vpclattice now available in aws-sdk-go v1, we dont need to override it anymore #308

Tested:

  • unit tests
  • single e2e test:
HTTPRoute Creation Order #1: serviceImport, httpRoute, serviceExport, & service creates successfully
...
Ran 1 of 11 Specs in 483.247 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 10 Skipped
--- PASS: TestIntegration (484.11s)

rlymbur
rlymbur approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@rlymbur rlymbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mikhail-aws mikhail-aws merged commit f5f17fd into aws:main Aug 10, 2023
@mikhail-aws mikhail-aws deleted the remove-sdk-override branch August 10, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlymbur rlymbur rlymbur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikhail-aws @rlymbur