Improved assertions & resource clean-up for E2E tests #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijun726911
reviewed
Aug 4, 2023
| retrievedTargets, err := testFramework.LatticeClient.ListTargetsAsList(ctx, &vpclattice.ListTargetsInput{ | ||
| TargetGroupIdentifier: targetGroup.Id, | ||
| }) | ||
| Expect(err).ToNot(HaveOccurred()) |
There was a problem hiding this comment.
We could actually remove the whole:
testFramework.ExpectDeleted(ctx, service)
Eventually(func(g Gomega) {
log.Println("Verifying Targets are only craeted for the port defined in Port Annotaion in ServiceExport")
targets := testFramework.GetTargets(ctx, targetGroup, deployment)
Expect(len(targets) == 0)
}).WithTimeout(5*time.Minute + 30*time.Second)
This test case intend to test "Verifying Targets are only created for the port defined in Port Annotation in ServiceExport", and the delete k8sService and verify 0 targets don't need to be part of this test
There was a problem hiding this comment.
Got it, I have removed it now
| Logger(ctx).Infof("Target group %s no longer has targets registered. Deleting now.", *tgId) | ||
| Eventually(func() bool { | ||
| _, err := env.LatticeClient.DeleteTargetGroup(&vpclattice.DeleteTargetGroupInput{ | ||
| TargetGroupIdentifier: tgId, |
Pull Request Test Coverage Report for Build 5764738532
💛 - Coveralls |
mikhail-aws
reviewed
Aug 4, 2023
| @@ -35,7 +34,7 @@ func NewDefaultLattice(sess *session.Session, region string) *defaultLattice { | |||
| endpoint = latticeEndpoint | |||
| } | |||
|
|
|||
| latticeSess = vpclattice.New(sess, aws.NewConfig().WithRegion(region).WithEndpoint(endpoint)) | |||
| latticeSess = vpclattice.New(sess, aws.NewConfig().WithRegion(region).WithEndpoint(endpoint).WithMaxRetries(20)) | |||
There was a problem hiding this comment.
VPC lattice cp api have pretty low per account throttling setting, controller and e2etest code can quite easily get "Too Many Request" error if we use default max retry
There was a problem hiding this comment.
are these retries with exponential backoff? or whats the retry strategy?
|
overall looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
This addresses E2E reliability by improving assertions and clean-up of resources that may leak during E2E test executions. It also addresses Amazon VPC Lattice throttling exceptions by introducing a retry strategy for the VPC Lattice client.
What does this PR do / Why do we need it:
This improves the reliability of existing E2E tests.
Testing done on this change:
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No.
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
This will not break upgrades or downgrades. These changes were tested on the latest
v0.0.15release.Does this PR introduce any user-facing change?:
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.