Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up resources after test run #296

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

scottlaiaws
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix: bug

What does this PR do / Why do we need it: this PR fix clean up issue for test Test 2 listeners gateway with weighted httproute rules and service export import

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue: N/A

Testing done on this change:

make e2etest output:

Ran 7 of 7 Specs in 2926.795 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (2927.51s)
PASS
ok      github.com/aws/aws-application-networking-k8s/test/suites/integration   2927.541s

Automation added to e2e: N/A

Will this PR introduce any new dependencies?: No

Will this break upgrades or downgrades. Has updating a running cluster been tested?: N/A

Does this PR introduce any user-facing change?: No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scottlaiaws
Copy link
Contributor Author

make presubmit output:

go mod tidy
go generate ./...
go vet ./...
go fmt ./...
go test ./pkg/... -coverprofile coverage.out
?       github.com/aws/aws-application-networking-k8s/pkg/aws   [no test files]
ok      github.com/aws/aws-application-networking-k8s/pkg/aws/services  0.192s  coverage: 2.9% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/config        0.463s  coverage: 77.4% of statements
?       github.com/aws/aws-application-networking-k8s/pkg/k8s   [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/model/lattice [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/runtime       [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/utils [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/utils/retry   [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/utils/ttime   [no test files]
ok      github.com/aws/aws-application-networking-k8s/pkg/deploy        0.402s  coverage: 20.6% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/deploy/externaldns    0.582s  coverage: 77.8% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/deploy/lattice        0.812s  coverage: 86.1% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/gateway       1.017s  coverage: 77.8% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/latticestore  0.994s  coverage: 73.3% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/model/core    1.053s  coverage: 40.9% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/model/core/graph      0.984s  coverage: 17.2% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/utils/log     1.008s  coverage: 0.0% of statements [no tests to run]

@coveralls
Copy link

coveralls commented Jul 13, 2023

Pull Request Test Coverage Report for Build 5548460761

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.212%

Totals Coverage Status
Change from base Build 5545921376: 0.0%
Covered Lines: 3472
Relevant Lines: 10454

💛 - Coveralls

Copy link
Contributor

@zijun726911 zijun726911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottlaiaws scottlaiaws merged commit e46c433 into aws:main Jul 13, 2023
@scottlaiaws scottlaiaws deleted the test branch July 14, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants