Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issue with getting started doc #290

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix small issue with getting started doc #290

merged 1 commit into from
Jul 10, 2023

Conversation

graehren
Copy link
Collaborator

@graehren graehren commented Jul 5, 2023

This CR fixes a small syntax error in the latest getting started docs.

What type of PR is this?
documentation

Which issue does this PR fix:
N/a

What does this PR do / Why do we need it:
Fixes syntax error when running getting started docs. When running the docs in ZSH or running them a second time there could be additional httpRoute entries and we need to specify the first one.

Testing done on this change:
Running through getting started with a clean environment

Automation added to e2e:
N/a

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
testing in running cluster

Does this PR introduce any user-facing change?:
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Jul 5, 2023

Pull Request Test Coverage Report for Build 5466734015

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.692%

Totals Coverage Status
Change from base Build 5425923024: 0.0%
Covered Lines: 3382
Relevant Lines: 10345

💛 - Coveralls

@liwenwu-amazon liwenwu-amazon requested a review from solmonk July 5, 2023 18:01
@zijun726911 zijun726911 merged commit 47a507a into aws:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants